Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17](backport #38421) Make log messages in the file scanner less noisy #40555

Merged
merged 5 commits into from
Aug 19, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 19, 2024

  • Demote warning about empty files to the Debug level
  • Demote warnings about files too small to the Debug level
  • Improve wording, so it does not sound like an error

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

cd ./filebeat/input/filestream
go test

Related issues

* Demote warning about empty files to the Debug level
* Demote warnings about files too small to the Debug level
* Improve wording, so it does not sound like an error

(cherry picked from commit 4df595f)
@mergify mergify bot requested a review from a team as a code owner August 19, 2024 13:33
@mergify mergify bot added the backport label Aug 19, 2024
@mergify mergify bot assigned rdner Aug 19, 2024
@mergify mergify bot requested review from rdner and mauri870 and removed request for a team August 19, 2024 13:33
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 19, 2024
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Aug 19, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 19, 2024
@rdner
Copy link
Member

rdner commented Aug 19, 2024

@VihasMakwana @mauri870 just a note, we usually don't modify the code in backports. It's easier to backport follow up PRs this way. We should be able to merge any backport without fixing linter issues.

@rdner rdner enabled auto-merge (squash) August 19, 2024 15:49
@mauri870
Copy link
Member

@VihasMakwana @mauri870 just a note, we usually don't modify the code in backports. It's easier to backport follow up PRs this way. We should be able to merge any backport without fixing linter issues.

Thanks. Shall I revert the changes we pushed for the linter?

@rdner rdner merged commit 6d03e90 into 7.17 Aug 19, 2024
27 of 30 checks passed
@rdner rdner deleted the mergify/bp/7.17/pr-38421 branch August 19, 2024 16:24
@rdner
Copy link
Member

rdner commented Aug 19, 2024

@mauri870 it's okay in this particular case, just a note for the future 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants