tests: fix check to enable the race detector in supported platforms #40764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code is almost 4 years old, the support for the race detector was lacking at that point and Elastic had its first steps with arm64 builds of Beats. I updated the check to allow tests to run with RACE_DETECTOR=true in supported platforms, this includes linux/arm64 and darwin/arm64.
mauri870
added
cleanup
Team:Elastic-Agent-Data-Plane
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
botelastic
bot
added
needs_team
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
|
mergify
bot
added
the
backport-8.x
mauri870
commented
Sep 11, 2024
mauri870
added
backport-skip
mauri870
force-pushed
the
test-race-supported-platforms
branch
from
1442548
to
8050139
Compare
faec
approved these changes
Sep 13, 2024
leehinman
approved these changes
Sep 13, 2024
|
@mauri870 any reason why we are not backporting this to 8.x branch? |
I think I should clarify what is worth backporting. This is a minor change to support RACE on arm64, not a bug fix or anything significant enough to justify backporting, so I added the skip-backport label. |
|
@pierrehilbert Should I open a backport PR to 8.x manually? |
|
I think this is something we could use in 8.x branches too but I don't have strong opinion here, more difficult for me to find reason not to backport it. |
mauri870
added
backport-8.x
mergify bot
pushed a commit
that referenced
this pull request
Sep 16, 2024
…40764) * tests: fix check to enable the race detector in supported platforms This code is almost 4 years old, the support for the race detector was lacking at that point and Elastic had its first steps with arm64 builds of Beats. I updated the check to allow tests to run with RACE_DETECTOR=true in supported platforms, this includes linux/arm64 and darwin/arm64. * add log if race is enabled for an unsupported platform (cherry picked from commit a4387db)
Merged
6 tasks
pierrehilbert
pushed a commit
that referenced
this pull request
Sep 17, 2024
…40764) (#40847) * tests: fix check to enable the race detector in supported platforms This code is almost 4 years old, the support for the race detector was lacking at that point and Elastic had its first steps with arm64 builds of Beats. I updated the check to allow tests to run with RACE_DETECTOR=true in supported platforms, this includes linux/arm64 and darwin/arm64. * add log if race is enabled for an unsupported platform (cherry picked from commit a4387db) Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This code is almost 4 years old, the support for the race detector was
lacking at that point and Elastic had its first steps with arm64 builds of Beats.
I updated the check to allow tests to run with RACE_DETECTOR=1 in supported
platforms, this includes linux/arm64 and darwin/arm64.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Try running tests on arm64 platforms with RACE_DETECTOR=1