Enhance node_stats metricset with index stats #4077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the index stats were added to the node_stats metricset. This allows to fetch the metric stats from each node instead of globally. The difference between these stats is that these are node specific. That means if there are multiple shards / replicas the sum of all doc counts from all nodes is not the same as the doc count in all indices. Remove stats metricset as not needed anymore.
ruflin
force-pushed
the
index-to-node-stats
branch
from
69750d4 to
b87115b
Compare
|
LGTM |
monicasarbu
approved these changes
Apr 21, 2017
|
jenkins, retest it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the index stats were added to the node_stats metricset. This allows to fetch the metric stats from each node instead of globally. The difference between these stats is that these are node specific. That means if there are multiple shards / replicas the sum of all doc counts from all nodes is not the same as the doc count in all indices.
Remove stats metricset as not needed anymore.