Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change codeowners for enterprise-search #40796

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

tutelaris
Copy link
Member

Description

As an initiative to rename teams in the Search org from ent-search-* to search-*, it's required to change the code owners here.

This PR is dedicated to changing the codeowners file.

@tutelaris tutelaris self-assigned this Sep 12, 2024
@tutelaris tutelaris requested a review from a team as a code owner September 12, 2024 17:35
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 12, 2024
@botelastic
Copy link

botelastic bot commented Sep 12, 2024

This pull request doesn't have a Team:<team> label.

Copy link
Contributor

mergify bot commented Sep 12, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @tutelaris? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Sep 12, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 12, 2024
@tutelaris
Copy link
Member Author

@elastic/ingest-eng-prod, can you please add @elastic/ent-search-application team to the repo?

@kderusso
Copy link
Member

@tutelaris - Do we want to use @elastic/ent-search-application or should we migrate to some of the newer groups, e.g. @elastic/search-relevance , @elastic/search-experiences , @elastic/search-extract-and-transform , and @elastic/search-inference-team ? Alternately should we consider renaming to something like @elastic/search-team?

@rowlandgeoff
Copy link
Contributor

@elastic/ingest-eng-prod, can you please add @elastic/ent-search-application team to the repo?

@tutelaris Done. elastic/ent-search-application team now have write access. Shall I remove access for elastic/ent-search-application-backend? (Probably after you merge?) Or... is this going to change again based on Kathleen's comment?

@tutelaris
Copy link
Member Author

@tutelaris - Do we want to use @elastic/ent-search-application or should we migrate to some of the newer groups, e.g. @elastic/search-relevance , @elastic/search-experiences , @elastic/search-extract-and-transform , and @elastic/search-inference-team ? Alternately should we consider renaming to something like @elastic/search-team?

We decided to keep the @elastic/ent-search-application team to match with @app-search-team team in Slack

@tutelaris
Copy link
Member Author

@elastic/ingest-eng-prod, can you please add @elastic/ent-search-application team to the repo?

@tutelaris Done. elastic/ent-search-application team now have write access. Shall I remove access for elastic/ent-search-application-backend? (Probably after you merge?) Or... is this going to change again based on Kathleen's comment?

Thank you!
No, you can remove the backend team.

@tutelaris tutelaris added backport and removed backport-8.x Automated backport to the 8.x branch with mergify labels Sep 13, 2024
Copy link
Contributor

mergify bot commented Sep 13, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 13, 2024
@tutelaris
Copy link
Member Author

Hey @rowlandgeoff , can you please re-review this PR? Thank you!

Copy link
Contributor

@rowlandgeoff rowlandgeoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have removed access for the ent-search-application-backend team.

@tutelaris tutelaris merged commit 6ab7467 into elastic:main Sep 13, 2024
9 checks passed
mergify bot pushed a commit that referenced this pull request Sep 13, 2024
rowlandgeoff pushed a commit that referenced this pull request Sep 13, 2024
(cherry picked from commit 6ab7467)

Co-authored-by: Klim Markelov <klim.markelov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport backport-8.x Automated backport to the 8.x branch with mergify needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants