Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.15](backport #40536) [vSphere] Add new Cluster metricset manual backport #40828

Merged
merged 4 commits into from
Sep 14, 2024
Merged

[8.15](backport #40536) [vSphere] Add new Cluster metricset manual backport #40828

merged 4 commits into from
Sep 14, 2024

Conversation

ishleenk17
Copy link
Contributor

This is a manual backport of pull request #40536.

  • Enhancement

Description

Added following new metrics for the datastore metricset in the vSphere metricbeat module. added new performance API to get more detailed info from the vSphere.

Metrics Type Metrics Field Mappings
Cluster Summry  
ClusterComputeResource.Host cluster.host_names
ClusterComputeResource.Datastore cluster.datastore_names
ClusterComputeResource.Network cluster.network_names
ClusterComputeResource.Configuration.DasConfig.Enabled cluster.das_config.enabled
ClusterComputeResource.Configuration.DasConfig.AdmissionControlEnabled cluster.das_config.admission.control.enabled

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@niraj-elastic @niraj-crest
@shmsr @ishleenk17
[vSphere] Add new Cluster metricset (#40536)
cd2b38f 
* add cluster metricset

* update changelog

* fix lint errors

* minor changes

* add unit test

* update fields.yml

* mage update

* minor changes

* minor changes

* mage update

* Address review comment

* Address review comments

* address review comments

* update data.json

* update fields.yml

* update data.json

* lint changes

* mage update

* mage update for x-pack

* Mage update after conflicts

* update fields.go

* Address review comments

---------

Co-authored-by: Niraj Rathod <niraj.rathod@crestdatasys.com>
Co-authored-by: subham sarkar <subham.sarkar@elastic.co>
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 14, 2024
@botelastic
Copy link

botelastic bot commented Sep 14, 2024

This pull request doesn't have a Team:<team> label.

@shmsr shmsr marked this pull request as ready for review September 14, 2024 09:57
@shmsr shmsr requested review from a team as code owners September 14, 2024 09:57
@shmsr shmsr requested review from mauri870 and leehinman and removed request for a team September 14, 2024 09:57
@ishleenk17 ishleenk17 merged commit 095284f into 8.15 Sep 14, 2024
28 of 29 checks passed
@ishleenk17 ishleenk17 deleted the vsphere/bp_manual/pr-40536 branch September 14, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shmsr shmsr shmsr approved these changes

@mauri870 mauri870 Awaiting requested review from mauri870 mauri870 is a code owner automatically assigned from elastic/elastic-agent-data-plane

@leehinman leehinman Awaiting requested review from leehinman leehinman is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@ishleenk17 ishleenk17

Labels
needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ishleenk17 @shmsr @niraj-elastic