Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libbeat/cfgfile: remove futile errors.Is call #40851

Merged
merged 1 commit into from
Sep 30, 2024
Merged

libbeat/cfgfile: remove futile errors.Is call #40851

merged 1 commit into from
Sep 30, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Sep 16, 2024

Found while investigating another issue.

Proposed commit message

Also remove the no-lint directive and use errors.As to identify the type of the error returned by createRunner.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6
libbeat/cfgfile: remove futile errors.Is call
a8d60a1 
Also remove the no-lint directive and use errors.As to identify the type of
the error returned by createRunner.
@efd6 efd6 added libbeat cleanup backport-skip Skip notification from the automated backport with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Sep 16, 2024
@efd6 efd6 self-assigned this Sep 16, 2024
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 16, 2024
@efd6
Copy link
Contributor Author

efd6 commented Sep 17, 2024

/test

1 similar comment
@efd6
Copy link
Contributor Author

efd6 commented Sep 17, 2024

/test

@efd6 efd6 marked this pull request as ready for review September 18, 2024 00:36
@efd6 efd6 requested a review from a team as a code owner September 18, 2024 00:36
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@pierrehilbert pierrehilbert requested review from faec and removed request for khushijain21 September 25, 2024 13:36
@efd6 efd6 merged commit 98d34a8 into elastic:main Sep 30, 2024
124 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdner rdner rdner approved these changes

@faec faec Awaiting requested review from faec

Assignees

@efd6 efd6

Labels
backport-skip Skip notification from the automated backport with mergify cleanup libbeat Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efd6 @elasticmachine @rdner