Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.github/CODEOWNERS - remove non-existent metricbeat paths #40858

Merged
merged 1 commit into from
Sep 17, 2024
Merged

.github/CODEOWNERS - remove non-existent metricbeat paths #40858

merged 1 commit into from
Sep 17, 2024

Conversation

andrewkroh
Copy link
Member

Proposed commit message

These paths do not exist so they should not be part of the codeowners file.

/x-pack/metricbeat/module/gcp/dns
/x-pack/metricbeat/module/gcp/firewall
/x-pack/metricbeat/module/gcp/vpcflow

@andrewkroh
.github/CODEOWNERS - remove non-existent metricbeat paths
8dbb2e9 
These paths do not exist so they should not be part of the
codeowners file.

/x-pack/metricbeat/module/gcp/dns
/x-pack/metricbeat/module/gcp/firewall
/x-pack/metricbeat/module/gcp/vpcflow
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 17, 2024
@botelastic
Copy link

botelastic bot commented Sep 17, 2024

This pull request doesn't have a Team:<team> label.

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 17, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @andrewkroh? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 17, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 17, 2024
@andrewkroh andrewkroh marked this pull request as ready for review September 17, 2024 14:27
@andrewkroh andrewkroh requested a review from a team as a code owner September 17, 2024 14:27
@andrewkroh andrewkroh merged commit 9164f82 into elastic:main Sep 17, 2024
9 checks passed
@andrewkroh andrewkroh deleted the bugfix/codeowners-remove-mb-modules branch September 17, 2024 15:18
mergify bot pushed a commit that referenced this pull request Sep 17, 2024
@andrewkroh @mergify
.github/CODEOWNERS - remove non-existent metricbeat paths (#40858)
754cf1c 
These paths do not exist so they should not be part of the
codeowners file.

/x-pack/metricbeat/module/gcp/dns
/x-pack/metricbeat/module/gcp/firewall
/x-pack/metricbeat/module/gcp/vpcflow

(cherry picked from commit 9164f82)
@mergify mergify bot mentioned this pull request Sep 17, 2024
Merged
andrewkroh added a commit that referenced this pull request Sep 17, 2024
@mergify @andrewkroh
.github/CODEOWNERS - remove non-existent metricbeat paths (#40858) (#…
988ea72 
…40861)

These paths do not exist so they should not be part of the
codeowners file.

/x-pack/metricbeat/module/gcp/dns
/x-pack/metricbeat/module/gcp/firewall
/x-pack/metricbeat/module/gcp/vpcflow

(cherry picked from commit 9164f82)

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rowlandgeoff rowlandgeoff rowlandgeoff approved these changes

Assignees

@andrewkroh andrewkroh

Labels
backport-8.x Automated backport to the 8.x branch with mergify needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewkroh @rowlandgeoff