Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.15](backport #40686) x-pack/metricbeat/module/panw: Add a new module #40866

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 17, 2024

Proposed commit message

The Metricbeat panos module collects metrics from a Palo Alto firewall. It contains metricsets corresponding to the following requirements:

  • Temperature
  • HA Interfaces
  • Logical interfaces
  • Power consumption alarms
  • Fan alarms
  • Disk use
  • BGP status
  • IPSec Tunnels
  • GlobalProtect sessions
  • GlobalProtect Gateway utilization
  • System resources
  • License expiration
  • Certificate expirations

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

This is a new module and does not affect other modules.

How to test this PR locally

I have not created tests yet for this. Looking at other modules there seems to be a variety of approaches, so I would be looking for some guidance on this.


This is an automatic backport of pull request #40686 done by [Mergify](https://mergify.com).

* initial module creation

* panos.system metricset running

* remove testing data

* panos.disk metricset working

* rename metricset

* change metricset name

* bgp_peers metricset working

* temperature metricset

* more metricsets

* use MetricSetFields

* license notices

* update fields.yml

* added doc

* refactor down to 4 metricsets

* more cleanup

* cleanup field names

* remove yml

* panos.yml.disabled

* PR comment fixes

* more PR comments addressed. Still to do: tests

* Changes to:
	- move tunnels from vpn to interfaces metricset
	- address PR comments for field names in field.yml
	- split local/peer addresses into host and port for bgp
	- handle license expires of "never"

* Fixes for PR comments

* add license header

* add pango package

* mage check && mage update

* remove mappings & make update

* make linter happy

* add the untracked docs

* update the fields.yml

* update the fields.yml with example fields to make python integ tests happy

* make docs check happy and update codeowners

* add result of 'mage update' in x-pack/metricbeat

---------

Co-authored-by: subham sarkar <subham.sarkar@elastic.co>
Co-authored-by: tommyers-elastic <106530686+tommyers-elastic@users.noreply.github.com>
(cherry picked from commit cc2c925)

# Conflicts:
#	go.mod
#	x-pack/metricbeat/metricbeat.reference.yml
@mergify mergify bot added the backport label Sep 17, 2024
@mergify mergify bot requested a review from a team as a code owner September 17, 2024 20:40
@mergify mergify bot added the conflicts There is a conflict in the backported pull request label Sep 17, 2024
@mergify mergify bot requested review from a team as code owners September 17, 2024 20:40
@mergify mergify bot requested review from khushijain21 and VihasMakwana and removed request for a team September 17, 2024 20:40
Copy link
Contributor Author

mergify bot commented Sep 17, 2024

Cherry-pick of cc2c925 has failed:

On branch mergify/bp/8.15/pr-40686
Your branch is up to date with 'origin/8.15'.

You are currently cherry-picking commit cc2c92571f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/CODEOWNERS
	modified:   NOTICE.txt
	modified:   go.sum
	modified:   metricbeat/docs/fields.asciidoc
	new file:   metricbeat/docs/modules/panw.asciidoc
	new file:   metricbeat/docs/modules/panw/interfaces.asciidoc
	new file:   metricbeat/docs/modules/panw/routing.asciidoc
	new file:   metricbeat/docs/modules/panw/system.asciidoc
	new file:   metricbeat/docs/modules/panw/vpn.asciidoc
	modified:   metricbeat/docs/modules_list.asciidoc
	modified:   x-pack/metricbeat/include/list.go
	new file:   x-pack/metricbeat/module/panw/_meta/config.yml
	new file:   x-pack/metricbeat/module/panw/_meta/docs.asciidoc
	new file:   x-pack/metricbeat/module/panw/_meta/fields.yml
	new file:   x-pack/metricbeat/module/panw/_meta/testdata/bgp_peers.xml
	new file:   x-pack/metricbeat/module/panw/client.go
	new file:   x-pack/metricbeat/module/panw/config.go
	new file:   x-pack/metricbeat/module/panw/doc.go
	new file:   x-pack/metricbeat/module/panw/fields.go
	new file:   x-pack/metricbeat/module/panw/interfaces/_meta/data.json
	new file:   x-pack/metricbeat/module/panw/interfaces/_meta/docs.asciidoc
	new file:   x-pack/metricbeat/module/panw/interfaces/_meta/fields.yml
	new file:   x-pack/metricbeat/module/panw/interfaces/ha_interfaces.go
	new file:   x-pack/metricbeat/module/panw/interfaces/ifnet_interfaces.go
	new file:   x-pack/metricbeat/module/panw/interfaces/interface_types.go
	new file:   x-pack/metricbeat/module/panw/interfaces/interfaces.go
	new file:   x-pack/metricbeat/module/panw/interfaces/tunnels.go
	new file:   x-pack/metricbeat/module/panw/routing/_meta/data.json
	new file:   x-pack/metricbeat/module/panw/routing/_meta/docs.asciidoc
	new file:   x-pack/metricbeat/module/panw/routing/_meta/fields.yml
	new file:   x-pack/metricbeat/module/panw/routing/bgp_peers.go
	new file:   x-pack/metricbeat/module/panw/routing/routing.go
	new file:   x-pack/metricbeat/module/panw/routing/routing_types.go
	new file:   x-pack/metricbeat/module/panw/system/_meta/data.json
	new file:   x-pack/metricbeat/module/panw/system/_meta/docs.asciidoc
	new file:   x-pack/metricbeat/module/panw/system/_meta/fields.yml
	new file:   x-pack/metricbeat/module/panw/system/certificates.go
	new file:   x-pack/metricbeat/module/panw/system/fans.go
	new file:   x-pack/metricbeat/module/panw/system/filesystem.go
	new file:   x-pack/metricbeat/module/panw/system/license.go
	new file:   x-pack/metricbeat/module/panw/system/power.go
	new file:   x-pack/metricbeat/module/panw/system/resources.go
	new file:   x-pack/metricbeat/module/panw/system/system.go
	new file:   x-pack/metricbeat/module/panw/system/system_types.go
	new file:   x-pack/metricbeat/module/panw/system/thermal.go
	new file:   x-pack/metricbeat/module/panw/util.go
	new file:   x-pack/metricbeat/module/panw/vpn/_meta/data.json
	new file:   x-pack/metricbeat/module/panw/vpn/_meta/docs.asciidoc
	new file:   x-pack/metricbeat/module/panw/vpn/_meta/fields.yml
	new file:   x-pack/metricbeat/module/panw/vpn/gp_sessions.go
	new file:   x-pack/metricbeat/module/panw/vpn/gp_stats.go
	new file:   x-pack/metricbeat/module/panw/vpn/vpn.go
	new file:   x-pack/metricbeat/module/panw/vpn/vpn_types.go
	new file:   x-pack/metricbeat/modules.d/panw.yml.disabled

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   go.mod
	both modified:   x-pack/metricbeat/metricbeat.reference.yml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 17, 2024
@botelastic
Copy link

botelastic bot commented Sep 17, 2024

This pull request doesn't have a Team:<team> label.

Copy link
Member

@shmsr shmsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving; only a couple of merge conflicts need to be resolved.

@tommyers-elastic tommyers-elastic enabled auto-merge (squash) September 17, 2024 21:13
@tommyers-elastic tommyers-elastic merged commit 35f3f78 into 8.15 Sep 17, 2024
120 of 123 checks passed
@tommyers-elastic tommyers-elastic deleted the mergify/bp/8.15/pr-40686 branch September 17, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants