File restructure by providers for add_cloud_metadata #4088
Conversation
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
1 similar comment
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
| @@ -0,0 +1,24 @@ | |||
| package actions | |||
There was a problem hiding this comment.
Not related to this change, but why is this package called actions? @andrewkroh
There was a problem hiding this comment.
At one point there was an actions folder and I think we decided in the original PR for this processor to move it into its own folder. Looks like I did the file move, but never updated the actual package name.
There was a problem hiding this comment.
Should I make some related changes by the way?
There was a problem hiding this comment.
Change is made, also applied on add_locale package.
BTW, could the reviewdog be taught to recognize such convention?
There was a problem hiding this comment.
Thanks.
For reviewdog, @7AC perhaps knows more.
There was a problem hiding this comment.
Reviewdog just does what golint does
| @@ -0,0 +1,24 @@ | |||
| package actions | |||
There was a problem hiding this comment.
At one point there was an actions folder and I think we decided in the original PR for this processor to move it into its own folder. Looks like I did the file move, but never updated the actual package name.
athom
force-pushed
the
separate-providers-for-add-cloud-metadata
branch
from
d04d9fb
to
66e7cf1
Compare
should follow the name of their current folder
|
jenkins, test it |
This PR is a follow up issue for #4023 , focus on adjusting the files structure according the cloud providers. makes it easier to spot which parts are specific to a provider and which is the shared code.