-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filebeat receiver and otel consumer output #40974
Conversation
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think adding more to the validation for the configuration would be nice to have. Like validating that the only output configured is the otelconsumer. Possibly injecting an the otelconsumer
in the case that it was not defined in the configuration.
But I don't want to block on that here, as I think we can keep iterating. Lets get this merged so we can start testing.
38946d8
to
55e5375
Compare
If this is blocking further progress I am OK approving this without additional tests, but let's track the need for more testing in a GH issue first so we don't just forget to do it. |
@cmacknz Definitely want to get this merged now, so we can get this being used by elastic-agent. I agree that more unit testing in that area would be good, but shouldn't block this PR. I filed this issue to track the additional coverage - #40977 Integration testing in elastic-agent will also be added for more coverage. |
@cmacknz Looks like this needs a @elastic/beats-tech-leads review to get this merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved to unblock
Codewise looks good, eager to have all the pieces together! |
Co-authored-by: Blake Rouse <blake.rouse@elastic.co>
Co-authored-by: Blake Rouse <blake.rouse@elastic.co>
66d5c70
to
bb7aaf2
Compare
* Add filebeat receiver and otel consumer output Co-authored-by: Blake Rouse <blake.rouse@elastic.co> (cherry picked from commit 8b93e1c) # Conflicts: # go.mod
Proposed commit message
This PR adds a filebeat receiver and an otelconsumer output. These can be used together to run filebeat as an otel receiver.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
None
Author's Checklist
How to test this PR locally
receiver_test.go
shows how receiver is created, started and stopped.could be used in the opentelemetry collector to add the filebeat receiver.
Configuration would look like:
Related issues
Use cases
Screenshots
Logs