Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[AWS Cloudwatch] Fix Tags for APIGW" #41109

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

ycombinator
Copy link
Contributor

Reverts #40755 because since that PR was merged, we're seeing the https://buildkite.com/elastic/beats-packaging-pipeline consistently failing like so when it tries to run mage package on Agentbeat:

# github.com/elastic/beats/v7/x-pack/agentbeat
/usr/local/go/pkg/tool/linux_amd64/link: running aarch64-linux-gnu-gcc failed: exit status 1
/usr/lib/gcc-cross/aarch64-linux-gnu/6/../../../../aarch64-linux-gnu/bin/ld.gold: internal error in maybe_apply_stub, at ../../gold/aarch64.cc:5407
collect2: error: ld returned 1 exit status
Error: running "go build -o build/golang-crossbuild/agentbeat-linux-arm64 -buildmode pie -gcflags=all=-N -l -tags=agentbeat -ldflags -X github.com/elastic/beats/v7/libbeat/version.buildTime=2024-10-03T12:37:52Z -X github.com/elastic/beats/v7/libbeat/version.commit=698951e8c895eff9d03a8d0ececadba3b8b4c6bb" failed with exit code 1

@ycombinator ycombinator requested review from a team as code owners October 3, 2024 22:04
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 3, 2024
@botelastic
Copy link

botelastic bot commented Oct 3, 2024

This pull request doesn't have a Team:<team> label.

Copy link
Contributor

mergify bot commented Oct 3, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @ycombinator? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Oct 3, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Oct 3, 2024
@ycombinator
Copy link
Contributor Author

CI is green on this PR but I don't see the https://buildkite.com/elastic/beats-packaging-pipeline step being run on this PR. Pinged @rowlandgeoff off-PR to ask why that might be. Without knowing if this step succeeds on this PR, its hard to say with 100% confidence that merging this PR will make main CI green again.

@ycombinator ycombinator enabled auto-merge (squash) October 4, 2024 01:02
@jlind23
Copy link
Collaborator

jlind23 commented Oct 4, 2024

@axw We might need your review on this to unblock Beats CI

Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to hopefully unblock CI, but there's nothing unusual in this PR, so seems like something more systemic needs addressing.

@ycombinator ycombinator merged commit c8ab313 into main Oct 4, 2024
142 checks passed
@ycombinator ycombinator deleted the revert-40755-awscloudwatchtags branch October 4, 2024 05:51
mergify bot pushed a commit that referenced this pull request Oct 4, 2024
pierrehilbert pushed a commit that referenced this pull request Oct 4, 2024
This reverts commit 5aca19c.

(cherry picked from commit c8ab313)

Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
@ycombinator
Copy link
Contributor Author

Approving to hopefully unblock CI, but there's nothing unusual in this PR, so seems like something more systemic needs addressing.

Thanks @axw. Yeah, nothing in the PR jumps out as the cause but this failure is (at least so far) only being observed with #40755. Since we've merged this revert PR here, we haven't seen the same failure on main. So it's something specific to #40755 that we'll need to dig into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants