Fix read-only instructions for running Beats on Docker #41120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilfoyle
added
docs
Team:Docs
botelastic
bot
added
needs_team
|
|
mergify
bot
added
the
backport-8.x
belimawr
reviewed
Oct 4, 2024
libbeat/docs/shared-docker.asciidoc
Outdated
Comment on lines
152
to
155
| docker run \ | ||
| --mount type=source=$(pwd}/data,destination=/usr/share/{beatname_lc}/data | ||
| --mount type=source=$(pwd)/data,destination=/usr/share/{beatname_lc}/data | ||
| --read-only | ||
| {dockerimage} |
There was a problem hiding this comment.
I managed to get it working with type=bind, I also noticed that some \ are missing making copy/paste not to work, here is my fixed version:
docker run --rm \
--mount type=bind,source=$(pwd)/data,destination=/usr/share/filebeat/data \
--read-only \
docker.elastic.co/beats/filebeat:8.15.2
There was a problem hiding this comment.
Awesome. Thanks @belimawr!
Here's how it looks now (I'm building the docs off of main but once published this would show an 8.15.2 Docker image):
pierrehilbert
added
Team:Elastic-Agent-Control-Plane
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
belimawr
approved these changes
Oct 7, 2024
VihasMakwana
approved these changes
Oct 7, 2024
mergify bot
pushed a commit
that referenced
this pull request
Oct 7, 2024
* Fix read-only instructions for running Beats on Docker * Fix up command (cherry picked from commit b7d7fec)
mergify bot
pushed a commit
that referenced
this pull request
Oct 7, 2024
* Fix read-only instructions for running Beats on Docker * Fix up command (cherry picked from commit b7d7fec)
This was referenced Oct 7, 2024
pierrehilbert
pushed a commit
that referenced
this pull request
Oct 7, 2024
pierrehilbert
added a commit
that referenced
this pull request
Oct 8, 2024
* Fix read-only instructions for running Beats on Docker * Fix up command (cherry picked from commit b7d7fec) Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com> Co-authored-by: Pierre HILBERT <pierre.hilbert@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@blakerouse, Bill noticed a couple of issues with the Run (beat) on a read-only file system instructions:
I believe:
$(pwd}should be$(pwd)type=....,source=This PR fixes up the first issue, but can you please help with the second? I'm not sure what the change should be, if any. I just copied that command from your comment here.