Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[filebeat][GCS] - Improved documentation #41143

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

ShourieG
Copy link
Contributor

@ShourieG ShourieG commented Oct 6, 2024

Type of change

  • Docs

Proposed commit message

Improved the existing documentation based on user feedback.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 6, 2024
@ShourieG ShourieG self-assigned this Oct 6, 2024
Copy link
Contributor

mergify bot commented Oct 6, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @ShourieG? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Oct 6, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Oct 6, 2024
@ShourieG ShourieG requested a review from a team October 6, 2024 06:54
@ShourieG ShourieG added the Team:Security-Service Integrations Security Service Integrations Team label Oct 6, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 6, 2024
@ShourieG ShourieG added docs needs_team Indicates that the issue/PR needs a Team:* label labels Oct 6, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 6, 2024
@ShourieG ShourieG added needs_team Indicates that the issue/PR needs a Team:* label input:GCS labels Oct 6, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 6, 2024
Copy link
Contributor

mergify bot commented Oct 8, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b gcs/improve_docs upstream/gcs/improve_docs
git merge upstream/main
git push upstream gcs/improve_docs

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits.

x-pack/filebeat/docs/inputs/input-gcs.asciidoc Outdated Show resolved Hide resolved
x-pack/filebeat/docs/inputs/input-gcs.asciidoc Outdated Show resolved Hide resolved
x-pack/filebeat/docs/inputs/input-gcs.asciidoc Outdated Show resolved Hide resolved
x-pack/filebeat/docs/inputs/input-gcs.asciidoc Outdated Show resolved Hide resolved
x-pack/filebeat/docs/inputs/input-gcs.asciidoc Outdated Show resolved Hide resolved
x-pack/filebeat/docs/inputs/input-gcs.asciidoc Outdated Show resolved Hide resolved
x-pack/filebeat/docs/inputs/input-gcs.asciidoc Outdated Show resolved Hide resolved
x-pack/filebeat/docs/inputs/input-gcs.asciidoc Outdated Show resolved Hide resolved
x-pack/filebeat/docs/inputs/input-gcs.asciidoc Outdated Show resolved Hide resolved
x-pack/filebeat/docs/inputs/input-gcs.asciidoc Outdated Show resolved Hide resolved
@ShourieG
Copy link
Contributor Author

ShourieG commented Oct 8, 2024

@kcreddy, @efd6, addressed all the PR suggestions.

@ShourieG ShourieG merged commit bc242ae into elastic:main Oct 8, 2024
22 checks passed
mergify bot pushed a commit that referenced this pull request Oct 8, 2024
@ShourieG ShourieG deleted the gcs/improve_docs branch October 9, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify docs input:GCS Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants