helper/hasher general improvements #41863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix a TOCTOU by opening the file handle and then doing stat(), instead of doning stat() and then opening. * Make sure this is a regular file, otherwise you could trick auditbeat into hashing an infinite source like a pipe. * Allow for rate (but not file size) to be infinite, this is needed for an upcoming new backend for module/system/process. * Finally, fix error messages that show up on ECS, see below. before: ``` failed to hash executable /d/e/beats/x-pack/auditbeat/auditbeat for PID 50751: failed to hash file /d/e/beats/x-pack/auditbeat/auditbeat: hasher: file size 143673152 exceeds max file size ``` after: ``` failed to hash executable /d/e/beats/x-pack/auditbeat/auditbeat for PID 50804: size 143673152 exceeds max file size ```
botelastic
bot
added
the
needs_team
haesbaert
added
backport-8.15
haesbaert
added
the
Team:Security-Linux Platform
|
Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform) |
botelastic
bot
removed
the
needs_team
nicholasberlin
approved these changes
Dec 3, 2024
mergify bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
* Fix a TOCTOU by opening the file handle and then doing stat(), instead of doning stat() and then opening. * Make sure this is a regular file, otherwise you could trick auditbeat into hashing an infinite source like a pipe. * Allow for rate (but not file size) to be infinite, this is needed for an upcoming new backend for module/system/process. * Finally, fix error messages that show up on ECS, see below. before: ``` failed to hash executable /d/e/beats/x-pack/auditbeat/auditbeat for PID 50751: failed to hash file /d/e/beats/x-pack/auditbeat/auditbeat: hasher: file size 143673152 exceeds max file size ``` after: ``` failed to hash executable /d/e/beats/x-pack/auditbeat/auditbeat for PID 50804: size 143673152 exceeds max file size ``` (cherry picked from commit 8b38b65)
3 tasks
mergify bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
* Fix a TOCTOU by opening the file handle and then doing stat(), instead of doning stat() and then opening. * Make sure this is a regular file, otherwise you could trick auditbeat into hashing an infinite source like a pipe. * Allow for rate (but not file size) to be infinite, this is needed for an upcoming new backend for module/system/process. * Finally, fix error messages that show up on ECS, see below. before: ``` failed to hash executable /d/e/beats/x-pack/auditbeat/auditbeat for PID 50751: failed to hash file /d/e/beats/x-pack/auditbeat/auditbeat: hasher: file size 143673152 exceeds max file size ``` after: ``` failed to hash executable /d/e/beats/x-pack/auditbeat/auditbeat for PID 50804: size 143673152 exceeds max file size ``` (cherry picked from commit 8b38b65)
3 tasks
mergify bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
* Fix a TOCTOU by opening the file handle and then doing stat(), instead of doning stat() and then opening. * Make sure this is a regular file, otherwise you could trick auditbeat into hashing an infinite source like a pipe. * Allow for rate (but not file size) to be infinite, this is needed for an upcoming new backend for module/system/process. * Finally, fix error messages that show up on ECS, see below. before: ``` failed to hash executable /d/e/beats/x-pack/auditbeat/auditbeat for PID 50751: failed to hash file /d/e/beats/x-pack/auditbeat/auditbeat: hasher: file size 143673152 exceeds max file size ``` after: ``` failed to hash executable /d/e/beats/x-pack/auditbeat/auditbeat for PID 50804: size 143673152 exceeds max file size ``` (cherry picked from commit 8b38b65)
3 tasks
mergify bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
* Fix a TOCTOU by opening the file handle and then doing stat(), instead of doning stat() and then opening. * Make sure this is a regular file, otherwise you could trick auditbeat into hashing an infinite source like a pipe. * Allow for rate (but not file size) to be infinite, this is needed for an upcoming new backend for module/system/process. * Finally, fix error messages that show up on ECS, see below. before: ``` failed to hash executable /d/e/beats/x-pack/auditbeat/auditbeat for PID 50751: failed to hash file /d/e/beats/x-pack/auditbeat/auditbeat: hasher: file size 143673152 exceeds max file size ``` after: ``` failed to hash executable /d/e/beats/x-pack/auditbeat/auditbeat for PID 50804: size 143673152 exceeds max file size ``` (cherry picked from commit 8b38b65)
3 tasks
haesbaert
added a commit
that referenced
this pull request
Dec 3, 2024
* Fix a TOCTOU by opening the file handle and then doing stat(), instead of doning stat() and then opening. * Make sure this is a regular file, otherwise you could trick auditbeat into hashing an infinite source like a pipe. * Allow for rate (but not file size) to be infinite, this is needed for an upcoming new backend for module/system/process. * Finally, fix error messages that show up on ECS, see below. before: ``` failed to hash executable /d/e/beats/x-pack/auditbeat/auditbeat for PID 50751: failed to hash file /d/e/beats/x-pack/auditbeat/auditbeat: hasher: file size 143673152 exceeds max file size ``` after: ``` failed to hash executable /d/e/beats/x-pack/auditbeat/auditbeat for PID 50804: size 143673152 exceeds max file size ``` (cherry picked from commit 8b38b65) Co-authored-by: Christiano Haesbaert <haesbaert@elastic.co>
haesbaert
added a commit
that referenced
this pull request
Dec 4, 2024
* Fix a TOCTOU by opening the file handle and then doing stat(), instead of doning stat() and then opening. * Make sure this is a regular file, otherwise you could trick auditbeat into hashing an infinite source like a pipe. * Allow for rate (but not file size) to be infinite, this is needed for an upcoming new backend for module/system/process. * Finally, fix error messages that show up on ECS, see below. before: ``` failed to hash executable /d/e/beats/x-pack/auditbeat/auditbeat for PID 50751: failed to hash file /d/e/beats/x-pack/auditbeat/auditbeat: hasher: file size 143673152 exceeds max file size ``` after: ``` failed to hash executable /d/e/beats/x-pack/auditbeat/auditbeat for PID 50804: size 143673152 exceeds max file size ``` (cherry picked from commit 8b38b65) Co-authored-by: Christiano Haesbaert <haesbaert@elastic.co>
haesbaert
added a commit
that referenced
this pull request
Dec 4, 2024
* Fix a TOCTOU by opening the file handle and then doing stat(), instead of doning stat() and then opening. * Make sure this is a regular file, otherwise you could trick auditbeat into hashing an infinite source like a pipe. * Allow for rate (but not file size) to be infinite, this is needed for an upcoming new backend for module/system/process. * Finally, fix error messages that show up on ECS, see below. before: ``` failed to hash executable /d/e/beats/x-pack/auditbeat/auditbeat for PID 50751: failed to hash file /d/e/beats/x-pack/auditbeat/auditbeat: hasher: file size 143673152 exceeds max file size ``` after: ``` failed to hash executable /d/e/beats/x-pack/auditbeat/auditbeat for PID 50804: size 143673152 exceeds max file size ``` (cherry picked from commit 8b38b65) Co-authored-by: Christiano Haesbaert <haesbaert@elastic.co>
haesbaert
added a commit
that referenced
this pull request
Dec 4, 2024
* Fix a TOCTOU by opening the file handle and then doing stat(), instead of doning stat() and then opening. * Make sure this is a regular file, otherwise you could trick auditbeat into hashing an infinite source like a pipe. * Allow for rate (but not file size) to be infinite, this is needed for an upcoming new backend for module/system/process. * Finally, fix error messages that show up on ECS, see below. before: ``` failed to hash executable /d/e/beats/x-pack/auditbeat/auditbeat for PID 50751: failed to hash file /d/e/beats/x-pack/auditbeat/auditbeat: hasher: file size 143673152 exceeds max file size ``` after: ``` failed to hash executable /d/e/beats/x-pack/auditbeat/auditbeat for PID 50804: size 143673152 exceeds max file size ``` (cherry picked from commit 8b38b65) Co-authored-by: Christiano Haesbaert <haesbaert@elastic.co>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
before:
after:
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
error.message will stop duplicating text.