-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.16](backport #41583) x-pack/filebeat/input/entityanalytics/provider/okta: Rate limiting fixes #41901
Conversation
Cherry-pick of 4e19d09 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still has conflicts
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
942d4e0
to
2fc7f46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conflicts fixed.
Since 8.16
doesn't have #41044, the changes in GetUserFactors
, GetUserRoles
and GetGroupRoles
are removed.
Proposed commit message
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Discussion
Can be reviewed commit-by-commit.
The reason a new
rate.Limiter
needs to be created whenx-rate-limit-remaining: 0
is that whilerate.Limiter
allows updating of the rate and burst, it doesn't allow clearing of existing tokens.Disruptive User Impact
None.
Related issues
This is an automatic backport of pull request x-pack/filebeat/input/entityanalytics/provider/okta: Rate limiting fixes #41583 done by Mergify.