Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(golangci): bump golangci-lint to 1.59.1 #42026

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/workflows/golangci-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
uses: golangci/golangci-lint-action@v6
with:
# Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
version: v1.55.2
version: v1.59.1

# Give the job more time to execute.
# Regarding `--whole-files`, the linter is supposed to support linting of changed a patch only but,
Expand All @@ -53,8 +53,5 @@ jobs:
# into fixing all linting issues in the whole file instead
args: --timeout=30m --whole-files

# Optional: if set to true then the action will use pre-installed Go.
skip-go-installation: true

# Optional: show only new issues if it's a pull request. The default value is `false`.
only-new-issues: true
11 changes: 1 addition & 10 deletions .golangci.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# options for analysis running
run:
concurrency: 0
# timeout for analysis, e.g. 30s, 5m, default is 1m
timeout: 15m
build-tags:
Expand Down Expand Up @@ -150,10 +151,6 @@ linters-settings:
- github.com/meraki/dashboard-api-go/v3
- github.com/snowflakedb/gosnowflake

gosimple:
# Select the Go version to target. The default is '1.13'.
go: "1.22.9"

nakedret:
# make an issue if func has more lines of code than this setting and it has naked returns; default is 30
max-func-lines: 0
Expand All @@ -170,20 +167,14 @@ linters-settings:

staticcheck:
# Select the Go version to target. The default is '1.13'.
go: "1.22.9"
checks: ["all"]

stylecheck:
# Select the Go version to target. The default is '1.13'.
go: "1.22.9"
# Disabled:
# ST1005: error strings should not be capitalized
checks: ["all", "-ST1005"]

unused:
# Select the Go version to target. The default is '1.13'.
go: "1.22.9"

gosec:
excludes:
- G306 # Expect WriteFile permissions to be 0600 or less
Expand Down
Loading