-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for recursive structures in packetbeat's ECS field handlers #42116
base: main
Are you sure you want to change the base?
Add support for recursive structures in packetbeat's ECS field handlers #42116
Conversation
Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform) |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM if CI agrees.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Fixes the bug at hand.
Proposed commit message
fixes #42108
This fixes the behavior of
MarshalMapStr()
so that it'll properly recurse through nested structs when turning theecs.Fields
object into a map. This might technically be a breaking change, since theprocess.parent
field willnow produce a different (but correct) map.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.