Fix import dashboards when ulimit -n is low #4246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsg
added
needs_backport
The unzip routine was deferring close functions in a loop, so it kept each file open. This adds a closure so the files are closed immediately. Fixes elastic#4244. This also improves the error handling to always report the original error.
tsg
force-pushed
the
fix_import_dashboards_too_many_open_files
branch
from
b24c887
to
ee7aee0
Compare
tsg
added a commit
to tsg/beats
that referenced
this pull request
May 8, 2017
The unzip routine was deferring close functions in a loop, so it kept each file open. This adds a closure so the files are closed immediately. Fixes elastic#4244. This also improves the error handling to always report the original error. (cherry picked from commit 8c5949f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unzip routine was deferring close functions in a loop, so it kept
each file open. This adds a closure so the files are closed immediately.
Fixes #4244.
This also improves the error handling to always report the original error.