Remove unnecessary print statement in schema apis #4355
Conversation
vjsamuel
force-pushed
the
remove_unnecessary_print
branch
from
3dcd1b7 to
4f495f1
Compare
|
jenkins test it |
| @@ -128,7 +128,6 @@ func StrFromNum(key string, opts ...schema.SchemaOption) schema.Conv { | |||
| func toStr(key string, data map[string]interface{}) (interface{}, error) { | |||
| emptyIface, err := common.MapStr(data).GetValue(key) | |||
| if err != nil { | |||
| fmt.Println(err) | |||
| return "", fmt.Errorf("Key %s not found", key) | |||
There was a problem hiding this comment.
The fmt must definitively be removed. But we should add it to the error that is returned:
return "", fmt.Errorf("Key %s not found: %s", key, err)
There was a problem hiding this comment.
@ruflin, we do return an error here. it can be left upto the consumer to decide if this needs to be logged or not. for instance I got this error when I had set the Conv to optionally extract a field out. It should be logging errors for such cases. that would just fill up my log file because there may be many fields that are set to optional. thought?
There was a problem hiding this comment.
I only mean to include the error in the error message.
CHANGELOG.asciidoc
Outdated
| @@ -43,7 +43,7 @@ https://github.com/elastic/beats/compare/v6.0.0-alpha1...master[Check the HEAD d | |||
| - Fix a debug statement that said a module wrapper had stopped when it hadn't. {pull}4264[4264] | |||
| - Use MemAvailable value from /proc/meminfo on Linux 3.14. {pull}4316[4316] | |||
| - Fix panic when events were dropped by filters. {issue}4327[4327] | |||
|
|
|||
| - Remove unnecessary print statement in schema apis {pull}4355[4355] | |||
There was a problem hiding this comment.
Can you add a newline afterwards?
vjsamuel
force-pushed
the
remove_unnecessary_print
branch
from
4f495f1 to
f80a712
Compare
|
jenkins, test it |
1 similar comment
|
jenkins, test it |
| @@ -128,7 +128,6 @@ func StrFromNum(key string, opts ...schema.SchemaOption) schema.Conv { | |||
| func toStr(key string, data map[string]interface{}) (interface{}, error) { | |||
| emptyIface, err := common.MapStr(data).GetValue(key) | |||
| if err != nil { | |||
| fmt.Println(err) | |||
| return "", fmt.Errorf("Key %s not found", key) | |||
There was a problem hiding this comment.
I only mean to include the error in the error message.
vjsamuel
force-pushed
the
remove_unnecessary_print
branch
from
798417d to
21641af
Compare
|
jenkins, test it |
vjsamuel
force-pushed
the
remove_unnecessary_print
branch
from
21641af to
0d63a8c
Compare
No description provided.