Cherry-pick various test fixes to 5.4 #4404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3562) The test can fail if some calls to statfs fail due to permission errors. For example: `stat("/var/lib/docker/aufs/mnt/50d0d5f599f0f19450e7649f73a0e23da1f172048e555df2b1cb78b3fefa355b", 0x7ffd2e5b8ed0) = -1 EACCES (Permission denied)`
Error string testing is brittle. The PR makes the test less stringent by not checking the full error message that includes the Golang stdlib error.
- Fix and enable the python smoke test for heartbeat - Remove fmt.Printf from metricbeat ceph module - Fix Windows path issues in libbeat/paths tests - Fix ioutil.TempDir usage in Packetbeat tests (it broke windows)
The thrift test config used double quotes around Windows path separators and this was interpreted incorrectly in YAML parsing.
This test doesn’t actually test any bad conditions. Plus there is another test in the same directory with the name TestBadCondition.
And in system tests, centralize the logic for asserting that there are no ERR or WARN in logs. Filter out errors about “The service process could not connect to the service controller” that occur when testing on Jenkins where Jenkins itself is running as a service. This confuses the Beat because it thinks that it is running as service, but it’s not.
The error message “no such file or directory” is an OS specific error message. There is a different error message on Windows. Simply checking for “error loading config file” should be sufficient.
The test was failing on Windows when `os.rename` failed with `[Error 3] The system cannot find the path specified`. The root cause of the failure was that the path was ~260 characters on Jenkins which is greater than the `MAX_PATH` value in Windows. This PR shortens the test log’s name to resolve the issue. The other changes to normalize the filepath are nice to have for Windows, but not strictly required.
Errors that are logged by the system/filesystem test case don’t have enough context to debug them. This adds the filesystem that caused the error to the message.
Use filepath.Clean on the configured paths to fix any invalid OS path separators. Skip the geoip test with symlinks on Windows (`os.symlink` isn’t supported on Windows).
Check for errors and exit to stop panics from occurring when the test fails. Increase the sleep to 750ms to give the checkpoint more time to flush states to disk.
The `computer_name` field in events is the full hostname, but the `win32api.GetComputerName` was returning the shortened netbios name. So the test fail on machines with longer hostnames.
Add filtering to system filesystem metricset to remove relative mountpoints like those from Linux network namespaces.
On our CI system we get the following error: ``` WindowsError: [Error 206] The filename or extension is too long: 'C:\\Users\\jenkins\\workspace\\elastic+beats+pull-request+multijob-windows\\beat\\filebeat\\label\\windows\\src\\github.com\\elastic\\beats\\filebeat\\build\\system-tests\\run\\test_prospector.Test.test_close_inactive_file_rotation_and_removal_while_new_file_created' ``` The problem is that this path is 267 characters long. According to https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx the MAX_PATH length is 260. In general it seems we could hit this limitation also in lots of other ways where we cannot just reduce the length of the test name. There seems to be some possibility to increase this limit: To specify an extended-length path, use the "\\?\" prefix. For example, "\\?\D:\very long path". We should test if this could also solve the problem as it raises the limit to 32767.
andrewkroh
force-pushed
the
5.4
branch
2 times, most recently
from
cb22f4a to
71b443a
Compare
|
A few Packetbeat tests are failing, but I'm not sure why. The python test code looks to be the same between my branch and 5.x where the tests are all passing. Would appreciate some help. Maybe we merge this as is (assuming AppVeyor, TravisCI, and most of beats-ci are passing). |
|
Let's merge this one only after 5.4.1 is released, I don't want to risk anything this late there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore permission errors in Metricbeat’s TestFileSystemList (Ignore permission errors in Metricbeat’s TestFileSystemList #3562)
The test can fail if some calls to statfs fail due to permission errors. For example:
stat("/var/lib/docker/aufs/mnt/50d0d5f599f0f19450e7649f73a0e23da1f172048e555df2b1cb78b3fefa355b", 0x7ffd2e5b8ed0) = -1 EACCES (Permission denied)Less strict error matching in Winlogbeat config_test
Error string testing is brittle. The PR makes the test less stringent by not checking the full error message that includes the Golang stdlib error.
Miscellaneous test fixes (Miscellaneous test fixes #4216)
Using single quotes around Windows paths (More test fixes #4235)
The thrift test config used double quotes around Windows path separators and this was interpreted incorrectly in YAML parsing.
Rename TestBadCondition to TestConditions (More test fixes #4235)
This test doesn’t actually test any bad conditions. Plus there is another test in the same directory with the name TestBadCondition.
Use logp.Beta or logp.Experimental in metricsets (More test fixes #4235)
And in system tests, centralize the logic for asserting that there are no ERR or WARN in logs.
Filter out errors about “The service process could not connect to the service controller” that occur when testing on Jenkins where Jenkins itself is running as a service. This confuses the Beat because it thinks that it is running as service, but it’s not.
Remove OS specific error message check from mockbeat (Remove OS specific error message check from mockbeat #4267)
The error message “no such file or directory” is an OS specific error message. There is a different error message on Windows. Simply checking for “error loading config file” should be sufficient.
Use shorter filename in Filebeat test for Windows (Use shorter filename in Filebeat test for Windows #4271)
The test was failing on Windows when
os.renamefailed with[Error 3] The system cannot find the path specified. The root cause of the failure was that the path was ~260 characters on Jenkins which is greater than theMAX_PATHvalue in Windows. This PR shortens the test log’s name to resolve the issue.The other changes to normalize the filepath are nice to have for Windows, but not strictly required.
Add filesystem name to test error message (Add filesystem name to test error message #4272)
Errors that are logged by the system/filesystem test case don’t have enough context to debug them. This adds the filesystem that caused the error to the message.
Clean geoip.paths before using the path (Clean geoip.paths before using the path #4306)
Improve winlogbeat checkpoint test (Improve winlogbeat checkpoint test #4371)
Fix Winlogbeat test by checking full hostname (Fix Winlogbeat test by checking full hostname #3942)
The
computer_namefield in events is the full hostname, but thewin32api.GetComputerNamewas returning the shortened netbios name. So the test fail on machines with longer hostnames.Filter relative mounts in system filesystem metricset (Filter relative mounts in system filesystem metricset #4370)
Add filtering to system filesystem metricset to remove relative mountpoints like those from Linux network namespaces.
Shorten Filebeat test name to shorten path for windows Shorten test name to shorten path for windows #4360