-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instance_name in GCE add_cloud_metadata processor #4414
Conversation
Can one of the admins verify this patch? |
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically on build-eu-00. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Thanks, can you sign the CLA, please? Should only take 5 mins. One question on the "name" key. Is it guaranteed to always be there? Or should we mark it as optional? |
Yes, the "name" field is always there. See https://cloud.google.com/compute/docs/reference/latest/instances#name |
jenkins, test it |
I think this also needs to be added to the |
Done ;) |
@BeLi4L you will need to run Also please add a line to Apart from that, LGTM :) thanks for contributing! |
Alright, fixed :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for green
jenkins test this please |
No description provided.