-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed socket scanning for tcp6 #4442
Conversation
Can one of the admins verify this patch? |
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically on build-eu-00. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
LGTM @tomaszrichert, can you add a bugfix line to jenkins test it please |
BTW, thank you so much for taking the time to research and fix this! 💯 |
Fixed 2 bugs:
|
Updated changelog. |
We don't publish roadmaps, but as soon as this is merged it should make it to the next release |
jenkins test it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but would be nice to add a test case for this to prevent a regression.
Add tests for elastic#4442
* Fixed socket scanning for tcp6 * Fixed ip6 parsing (cherry picked from commit 1426260)
* Add tests for latest ipv6 related fixes Add tests for #4442 * Fix error message We don't really know what file we are reading from, as it could be `/proc/net/tcp` or `/proc/net/tcp6`
Fixed issue with /proc/net/tcp6 not being scanned due to simple bug