Vsphere module: collect custom fields from virtual machines (#4464) #4469
Conversation
|
I think I made a little mess using rebase...My commit to fix used memory field is here too. If it's a problem, I can try to remove him. :-| |
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically on build-eu-00. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
jenkins test it please |
|
@amandahla you can always try to remove it using |
There was a problem hiding this comment.
PR is looking good, I have some questions:
- What do custom fields look like normally? I'm worried about mapping explosion
- Would it make sense to let the user decide if she wants them or not?
| // Get all custom fields. | ||
| customFieldsOk := true | ||
|
|
||
| fieldMap := make(map[int32]string) |
There was a problem hiding this comment.
This name can be misleading, perhaps customFieldsMap is more clear? what do you think?
|
@exekias Good point. I didn't think about it. I'll make the changes (including the name of the field to customFieldsMap). |
|
LGTM, jenkins test it |
|
@amandahla it seems test are failing because of an issue fixed in master, could you please rebase master so it can pass tests? |
|
@exekias Is something that I'm missing here? :-( |
|
jenkins test this please |
|
@amandahla Can you please rebase to master? |
|
There is a error on building filebeat. Is something that I did wrong? The branch has no conflicts. |
|
Hi @amandahla, now that #4462 is finally merged, perhaps you can rebase this PR? I think the error will go away |
To obtain custom fields values.
The test is missing this part because simulator doesn't have custom field manager.