Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add random startup delay to each metricset #4503

Merged
merged 1 commit into from
Jun 14, 2017

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Jun 14, 2017

Add random startup delay to each metricset to avoid the thundering herd problem. Fixes #4010.

Running with debug, at startup you will see:

2017/06/14 14:24:03.652815 wrapper.go:197: DBG  system/memory will start after 6.287460518s
2017/06/14 14:24:03.652818 wrapper.go:197: DBG  system/cpu will start after 1.102366376s
2017/06/14 14:24:03.652827 wrapper.go:197: DBG  system/load will start after 4.933446568s
2017/06/14 14:24:03.652838 wrapper.go:197: DBG  system/filesystem will start after 4.47437156s
2017/06/14 14:24:03.652847 wrapper.go:197: DBG  system/fsstat will start after 5.52497095s
2017/06/14 14:24:03.652823 wrapper.go:197: DBG  system/process_summary will start after 8.93791103s
2017/06/14 14:24:03.652837 wrapper.go:197: DBG  system/network will start after 1.274884509s
2017/06/14 14:24:03.652821 wrapper.go:197: DBG  system/process will start after 6.207285781s

Add random startup delay to each metricset to avoid the thundering herd problem. Fixes elastic#4010.
@andrewkroh andrewkroh force-pushed the bugfix/mb/thundering-herd branch from bb92d76 to 5b5c2bd Compare June 14, 2017 14:22
@andrewkroh
Copy link
Member Author

jenkins, test it

@andrewkroh
Copy link
Member Author

The test failure in Filebeat's test_reload.Test.test_load_configs seems unrelated to the change.

Copy link
Contributor

@tsg tsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tsg tsg merged commit 5c0766a into elastic:master Jun 14, 2017
@andrewkroh andrewkroh deleted the bugfix/mb/thundering-herd branch July 5, 2017 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants