Enable Cgo for Filebeat & Heartbeat #4546
Conversation
|
jenkins, package it |
filebeat/Makefile
Outdated
| @@ -7,6 +7,10 @@ TEST_ENVIRONMENT?=true | |||
| GOX_FLAGS=-arch="amd64 386 arm ppc64 ppc64le" | |||
| ES_BEATS?=.. | |||
|
|
|||
| TARGETS?="windows/amd64 windows/386 darwin/amd64" | |||
| TARGETS_OLD?="linux/amd64 linux/386" | |||
| CGO=true | |||
There was a problem hiding this comment.
Should we change this in the libbeat Makefile to make it default for all beats?
There was a problem hiding this comment.
I worry it would complicate the lives of the community beats. Also, it's still not enabled for Winlogbeat, but we could overwrite it in that one.
Overall, it seemed like a less risky move to do it per Beat, but it's true that we'll have to be careful to do this whenever we add a new Beat. Any strong arguments to make it the default?
There was a problem hiding this comment.
My only argument would be that if it breaks somewhere we know earlier. I see the community beats complication but would hope they use our packaging scripts, so they get it out of the box?
There was a problem hiding this comment.
Ok, I was on the fence about it, so I changed the PR to make CGO=true the default in all Beats, and overwrite it to false in Winlogbeat.
|
jenkins, package it |
|
Packaging tests are green: http://build-eu-00.elastic.co/job/beats-package-PR/107/ |
This is to enable plugin support, and to enable future support (during the 6.x cycle) for importing other C libraries. Metricbeat & Packetbeat already had Cgo enabled. We're leaving Winlogbeat without Cgo because we don't foresee a reason for it to need it. This change also affects the community Beats, but they can revert to pure-go by adding `CGO=false` in their Makefile. Switch Cgo to be the default
|
It was all green, but I rebased it to solve a CHANGELOG conflict. |
monicasarbu
added
v6.0.0-beta1
Filebeat
This is to enable plugin support, and to enable future support (during the
6.x cycle) for importing other C libraries.
Metricbeat & Packetbeat already had Cgo enabled. We're leaving Winlogbeat
without Cgo because we don't foresee a reason for it to need it.
This change also affects the community Beats, but they can revert to pure-go
by adding
CGO=falsein their Makefile.