Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use packetbeat protocols to publish beat.Event to new pipeline #4599

Merged
merged 1 commit into from
Jul 4, 2017

Conversation

urso
Copy link

@urso urso commented Jul 3, 2017

  • Use packetbeat protocols to publish beat.Event to new pipeline
  • Move flows to new publisher pipeline
  • Do not drop events on publish, if input is via pcap file (stabilize system
    tests with potential large number of transactions)
  • add fields, tags and processor settings to flows and analyzer plugins (requires docs updates)

Followup: I noticed quite some duplication in protocols unit tests, for capturing/handling transactions. Some additional cleanup providing helpers common functionality for protocols unit-testing will be provided.

@urso urso added in progress Pull request is currently in progress. refactoring labels Jul 3, 2017
@urso urso mentioned this pull request Jul 3, 2017
22 tasks
@urso urso force-pushed the pipeline/packetbeat branch from 9f0bf4f to 49e290a Compare July 4, 2017 01:20
@urso urso changed the title [WIP] Use packetbeat protocols to publish beat.Event to new pipeline Use packetbeat protocols to publish beat.Event to new pipeline Jul 4, 2017
@urso urso added review and removed in progress Pull request is currently in progress. labels Jul 4, 2017
- Use packetbeat protocols to publish beat.Event to new pipeline
- Move flows to new publisher pipeline
- Do not drop events on publish, if input is via pcap file (stabilize system
  tests with potential large number of transactions)
- add fields, tags and processor settings to flows and analyzer plugins
@urso urso force-pushed the pipeline/packetbeat branch from 49e290a to 1a35204 Compare July 4, 2017 11:33
@urso urso added the needs_docs label Jul 4, 2017
Copy link
Contributor

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFG

@exekias exekias merged commit f2aefc1 into elastic:master Jul 4, 2017
@dedemorton dedemorton mentioned this pull request Jul 25, 2017
42 tasks
@dedemorton dedemorton mentioned this pull request Dec 14, 2017
37 tasks
@dedemorton
Copy link
Contributor

The flows documentation now has the fields, tags, and processor settings, so I'm assuming that all the end-user docs are updated for this PR. I'm removing the needs_docs label. There's still a doc item open to update the dev docs for #4598, so that'll cover any remaining work required for the dev docs.

@urso urso deleted the pipeline/packetbeat branch February 19, 2019 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants