Add option to load the dashboards via the Kibana API #4682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monicasarbu
added
in progress
monicasarbu
force-pushed
the
load_dashboards_via_kibana
branch
3 times, most recently
from
1efd7a2 to
c493a5a
Compare
ruflin
reviewed
Jul 20, 2017
| } | ||
|
|
||
| cfg := dashboards.DashboardsConfig{ | ||
| /* prepare the Elasticsearch index pattern */ |
ruflin
reviewed
Jul 20, 2017
| } | ||
| indexSel := outil.MakeSelector(outil.FmtSelectorExpr(fmtstr, "")) | ||
| /* TLS config */ | ||
| /* |
ruflin
reviewed
Jul 20, 2017
| @@ -1,4 +1,4 @@ | |||
| :stack-version: 5.5.0 | |||
| :doc-branch: 5.5 | |||
| :stack-version: 5.6.0 | |||
There was a problem hiding this comment.
@monicasarbu did you run set-version for this?
@tsg Kind of concerned that we miss that somewhere else.
There was a problem hiding this comment.
That's not set by set_version, but it's part of the release checklist to update it. I think it's fine to be changed here.
|
jenkins, package it |
monicasarbu
force-pushed
the
load_dashboards_via_kibana
branch
2 times, most recently
from
9e66d5d to
725f4d6
Compare
monicasarbu
force-pushed
the
load_dashboards_via_kibana
branch
from
bff75d7 to
d827cb1
Compare
|
Tested manually with 6.0.0-beta1 and 5.4.1. Both seem to work fine. Nice work, @monicasarbu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to solve #4712
This PR adds the option to the
import_dashboardsscript to load the dashboards using the Kibana API. By default, theimport_dashboardsloads the dashboards to Elasticsearch. The same behavior has the-setupoption.This PR is a manual backport from master and it's customized for 5.6 branch. The motivation is that loading the dashboards in Beats 5.x to work with Elasticsearch 6.x version.