Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support npipe URLs in host parser #4751

Merged
merged 1 commit into from
Jul 26, 2017
Merged

Support npipe URLs in host parser #4751

merged 1 commit into from
Jul 26, 2017

Conversation

exekias
Copy link
Contributor

@exekias exekias commented Jul 25, 2017

Docker for Windows uses URLs like npipe://./pipe/docker_engine. This
change makes sure they are supported by our host validators

Fixes #4748

@exekias exekias mentioned this pull request Jul 25, 2017
Closed
@godefroi
Copy link

I built your Metricbeat (which thinks it's 7.0.0-alpha1 for some reason), ran metricbeat test modules and got this:

docker...
  container...OK
    result:
    {
     "command": "c:\\Consul\\consul.exe agent [snip]
     "created": "2017-06-22T14:52:19.000Z",
     "id": "12a828b16a91f1639a69b8eb6b97ff33ec719c5f2ee4c331920cc45d5b2b7e12",
     "image": "[snip]/consulagent",
     "labels": {
      "SERVICE_8301_IGNORE": "true",
      "SERVICE_8302_IGNORE": "true",
      "SERVICE_8400_IGNORE": "true",
      "SERVICE_8500_NAME": "consul_http",
      "SERVICE_8600_IGNORE": "true",
     },
     "name": "consulagent",
     "size": {
      "root_fs": 0,
      "rw": 0
     },
     "status": "Up 4 weeks"
    }

I believe that counts as success.

@exekias
Support npipe URLs in host parser
218dfd8 
Docker for Windows uses URLs like `npipe://./pipe/docker_engine`. This
change makes sure they are supported by our host validators
@exekias exekias force-pushed the fix-docker-npipe branch from 1109a52 to 218dfd8 Compare July 26, 2017 08:37
@exekias
Copy link
Contributor Author

exekias commented Jul 26, 2017

Rebased and added CHANGELOG, should be ready to go

@exekias exekias added the needs_backport PR is waiting to be backported to other branches. label Jul 26, 2017
@exekias
Copy link
Contributor Author

exekias commented Jul 26, 2017

jenkins retest this please

@andrewkroh andrewkroh merged commit 5750cc0 into elastic:master Jul 26, 2017
exekias added a commit to exekias/beats that referenced this pull request Jul 26, 2017
@exekias
Support npipe URLs in host parser (elastic#4751)
71e3903 
Docker for Windows uses URLs like `npipe://./pipe/docker_engine`. This
change makes sure they are supported by our host validators
(cherry picked from commit 5750cc0)
@exekias exekias mentioned this pull request Jul 26, 2017
Merged
@exekias exekias removed the needs_backport PR is waiting to be backported to other branches. label Jul 26, 2017
andrewkroh pushed a commit that referenced this pull request Jul 26, 2017
@exekias @andrewkroh
Support npipe URLs in host parser (#4751) (#4762)
e44948d 
Docker for Windows uses URLs like `npipe://./pipe/docker_engine`. This
change makes sure they are supported by our host validators
(cherry picked from commit 5750cc0)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@exekias @andrewkroh
Support npipe URLs in host parser (elastic#4751) (elastic#4762)
2f3c9ba 
Docker for Windows uses URLs like `npipe://./pipe/docker_engine`. This
change makes sure they are supported by our host validators
(cherry picked from commit f57163c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
bug Metricbeat Metricbeat review v6.0.0-GA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@exekias @godefroi @andrewkroh