Added breaking changes doc for 6.0 #4760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsg
added
docs
review
needs_backport
|
The overall structure makes sense. It seems a little odd to have the breaking changes for 5.0 in this document, tho, since we're duplicating what we have in the 5.0 docs. |
|
Yeah, it's probably better to remove them. Will do. |
urso
reviewed
Jul 27, 2017
libbeat/docs/breaking.asciidoc
Outdated
| - `publish_async` | ||
| - `idle_timeout` | ||
| - `queue_size` | ||
| - `bulk_queue_size` |
There was a problem hiding this comment.
naming:
- these settings live in filebeat namespace and are used like this on reference configs:
filebeat.spool_size,filebeat.publish_asyncandfilebeat.idle_timeout - these settings are 'global':
queue_sizeandbulk_max_size.
added 2 commits
August 10, 2017 11:56
Part of elastic#4737, but there are some TODOs left.
Also, addressed commits and removed the 5.0 breaking changes.
tsg
force-pushed
the
breaking_changes_docs
branch
from
c069736 to
e61146b
Compare
dedemorton
pushed a commit
to dedemorton/beats
that referenced
this pull request
Aug 14, 2017
* Added breaking changes doc for 6.0 Part of elastic#4737, but there are some TODOs left. * Add section for multiple outputs Also, addressed commits and removed the 5.0 breaking changes.
dedemorton
removed
the
needs_backport
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
* Added breaking changes doc for 6.0 Part of elastic#4737, but there are some TODOs left. * Add section for multiple outputs Also, addressed commits and removed the 5.0 breaking changes.
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
Backport to 6.0: elastic#4760 and elastic#4829
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4737.
Note that I didn't repeat everything from the release notes, but I just highlighted the things that are more likely to cause issues. See #4737 for short motivations on each item.
@urso Can you review the Spooler removal part, please?
@dedemorton Let me know please if the overall structure makes sense, happy to consider alternatives.