Fixing pod name indexer to use both namespace, pod name to frame index key #4775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
vjsamuel
force-pushed
the
fix_pod_name_indexer
branch
from
a361f84 to
08e4fba
Compare
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically on build-eu-00. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
exekias
approved these changes
Jul 27, 2017
| @@ -5,6 +5,8 @@ import ( | |||
|
|
|||
| "github.com/stretchr/testify/assert" | |||
|
|
|||
| "fmt" | |||
There was a problem hiding this comment.
could you please move this one next to "testing"?
There was a problem hiding this comment.
sorry i keep missing this always. done.
vjsamuel
force-pushed
the
fix_pod_name_indexer
branch
from
08e4fba to
95d1f56
Compare
|
jenkins test it please |
|
jenkins test it please |
vjsamuel
force-pushed
the
fix_pod_name_indexer
branch
from
9e8796e to
5cbbd3d
Compare
exekias
added
backport
bug
v6.0.0-GA
needs_backport
exekias
removed
the
needs_backport
exekias
pushed a commit
to exekias/beats
that referenced
this pull request
Aug 17, 2017
…x key (elastic#4775) * Fixing pod name indexer to use both namespace, pod name to frame index key * Adding field pattern matcher to support pod name indexer matching
andrewkroh
pushed a commit
that referenced
this pull request
Aug 17, 2017
…x key (#4775) * Fixing pod name indexer to use both namespace, pod name to frame index key * Adding field pattern matcher to support pod name indexer matching
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…x key (elastic#4775) * Fixing pod name indexer to use both namespace, pod name to frame index key * Adding field pattern matcher to support pod name indexer matching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we use only pod name in the index key for pod name indexer. With the advent of stateful sets, users can now spin up pods with consistent names like
zookeeper-1on multiple namespaces which can cause collision very easily. Hence it is mandatory for usingnamespace/podnameas the key for pod name indexer.