Basic RabbitMQ queues metricset #4788
Conversation
Related to #3887
|
Can one of the admins verify this patch? |
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically on build-eu-00. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
jenkins test it |
There was a problem hiding this comment.
Awesome contribution, thank you!!
I've left a comment, normally we generate example data.json thanks to system tests, I think it would make sense to add some for this metricset? Check https://github.com/elastic/beats/tree/master/metricbeat/tests/system
Also in the past I've seen
| "rabbitmq":{ | ||
| "queues":{ | ||
| "example": "queues" | ||
| } |
There was a problem hiding this comment.
It looks like some fields are missing from this example data.json, can you generate a complete one?
|
Hello, thanks for the feedback. I have an additional question about the naming conventions - currently the metricset is named 'queues' (as it collects information about queues). This results in the following keys - rabbitmq.queues.name, which looks slightly awkward. Is 'queue' is this case a better name for the metricset? |
|
I would say, |
| Total number of persistent messages in the queue (will always be 0 for transient queues). | ||
| - name: memory.bytes | ||
| type: long | ||
| description: > |
There was a problem hiding this comment.
Could you add here format: bytes? Like this Kibana will now it's a bytes value.
|
ok to test |
|
LGTM, ready to go, could you add a new entry to |
|
I have updated the changelog and rebased to the latest master. |
|
jenkins, test it please |
|
Sorry @kvalev, it took me a while to come back to this, could you please check the errors in https://beats-ci.elastic.co/job/elastic+beats+pull-request+multijob-intake/1504/console? Basically you need to run |
|
jenkins retest this please |
|
jenkins retest this please |
Extend the RabbitMQ metricbeat module with a metricset providing basic queue information. The data is retrieved from the RabbitMQ management API.
Related to #3887