-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filesystem.ignore_types to ignore filesystem types #4823
Add filesystem.ignore_types to ignore filesystem types #4823
Conversation
Add `filesystem.ignore_types` to the system module for ignoring filesystems in the `filesystem` and `fsstat` metricsets. The new configuration option accepts a list of filesystem types. metricbeat.modules: - module: system metricsets: [filesystem, fsstat] filesystem.ignore_types: [nfs, smbfs, proc, cgroups] Closes elastic#4685
jenkins, test it |
@dedemorton Could you please take a look at the docs I added for this option as well as the comment I put into the config file. I want to get it right before back-porting it to all the branches. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments. Otherwise, LGTM.
metricbeat/metricbeat.full.yml
Outdated
# A list of filesystem types to ignore. The filesystem metricset will not | ||
# collect data from filesystems matching any of the specified types and | ||
# fsstats will not include data from these filesystems in its summary stats. | ||
#filesystem.ignore_types: [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to populate the list with types that users commonly want to specify? Would be good to show as an example.
metricbeat/metricbeat.full.yml
Outdated
@@ -64,6 +64,11 @@ metricbeat.modules: | |||
# if true, exports the CPU usage in ticks, together with the percentage values | |||
#cpu_ticks: false | |||
|
|||
# A list of filesystem types to ignore. The filesystem metricset will not | |||
# collect data from filesystems matching any of the specified types and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comma before "and" to connect two independent clauses: ...any of the specified types, and
Another strategy to deal with these filesystems is to configure a `drop_event` | ||
filter that matches the `mount_point` using a regular expression. This type of | ||
filtering occurs after the data has been collected so it can be less efficient | ||
that the previous method. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: "than the previous method"
jenkins, test it |
* Add filesystem.ignore_types to ignore filesystem types Add `filesystem.ignore_types` to the system module for ignoring filesystems in the `filesystem` and `fsstat` metricsets. The new configuration option accepts a list of filesystem types. metricbeat.modules: - module: system metricsets: [filesystem, fsstat] filesystem.ignore_types: [nfs, smbfs, proc, cgroups] Closes elastic#4685 (cherry picked from commit 70caf0e)
* Add filesystem.ignore_types to ignore filesystem types Add `filesystem.ignore_types` to the system module for ignoring filesystems in the `filesystem` and `fsstat` metricsets. The new configuration option accepts a list of filesystem types. metricbeat.modules: - module: system metricsets: [filesystem, fsstat] filesystem.ignore_types: [nfs, smbfs, proc, cgroups] Closes #4685 (cherry picked from commit 70caf0e)
…elastic#4906) * Add filesystem.ignore_types to ignore filesystem types Add `filesystem.ignore_types` to the system module for ignoring filesystems in the `filesystem` and `fsstat` metricsets. The new configuration option accepts a list of filesystem types. metricbeat.modules: - module: system metricsets: [filesystem, fsstat] filesystem.ignore_types: [nfs, smbfs, proc, cgroups] Closes elastic#4685 (cherry picked from commit aa54a22)
#4918) * Add filesystem.ignore_types to ignore filesystem types Add `filesystem.ignore_types` to the system module for ignoring filesystems in the `filesystem` and `fsstat` metricsets. The new configuration option accepts a list of filesystem types. metricbeat.modules: - module: system metricsets: [filesystem, fsstat] filesystem.ignore_types: [nfs, smbfs, proc, cgroups] Closes #4685 (cherry picked from commit aa54a22)
…elastic#4906) (elastic#4918) * Add filesystem.ignore_types to ignore filesystem types Add `filesystem.ignore_types` to the system module for ignoring filesystems in the `filesystem` and `fsstat` metricsets. The new configuration option accepts a list of filesystem types. metricbeat.modules: - module: system metricsets: [filesystem, fsstat] filesystem.ignore_types: [nfs, smbfs, proc, cgroups] Closes elastic#4685 (cherry picked from commit 575483a)
Add
filesystem.ignore_types
to the system module for ignoring filesystemsin the
filesystem
andfsstat
metricsets. The new configuration optionaccepts a list of filesystem types.
Closes #4685