Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filesystem.ignore_types to ignore filesystem types #4823

Merged
merged 2 commits into from
Aug 15, 2017

Conversation

andrewkroh
Copy link
Member

Add filesystem.ignore_types to the system module for ignoring filesystems
in the filesystem and fsstat metricsets. The new configuration option
accepts a list of filesystem types.

metricbeat.modules:
- module: system
  metricsets: [filesystem, fsstat]
  filesystem.ignore_types: [nfs, smbfs, proc, cgroups]

Closes #4685

Add `filesystem.ignore_types` to the system module for ignoring filesystems
in the `filesystem` and `fsstat` metricsets. The new configuration option
accepts a list of filesystem types.

    metricbeat.modules:
    - module: system
      metricsets: [filesystem, fsstat]
      filesystem.ignore_types: [nfs, smbfs, proc, cgroups]

Closes elastic#4685
@andrewkroh andrewkroh added docs enhancement Metricbeat Metricbeat needs_backport PR is waiting to be backported to other branches. review labels Aug 3, 2017
@andrewkroh
Copy link
Member Author

jenkins, test it

@andrewkroh
Copy link
Member Author

@dedemorton Could you please take a look at the docs I added for this option as well as the comment I put into the config file. I want to get it right before back-porting it to all the branches. Thanks

@andrewkroh andrewkroh requested a review from dedemorton August 10, 2017 18:17
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments. Otherwise, LGTM.

# A list of filesystem types to ignore. The filesystem metricset will not
# collect data from filesystems matching any of the specified types and
# fsstats will not include data from these filesystems in its summary stats.
#filesystem.ignore_types: []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to populate the list with types that users commonly want to specify? Would be good to show as an example.

@@ -64,6 +64,11 @@ metricbeat.modules:
# if true, exports the CPU usage in ticks, together with the percentage values
#cpu_ticks: false

# A list of filesystem types to ignore. The filesystem metricset will not
# collect data from filesystems matching any of the specified types and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comma before "and" to connect two independent clauses: ...any of the specified types, and

Another strategy to deal with these filesystems is to configure a `drop_event`
filter that matches the `mount_point` using a regular expression. This type of
filtering occurs after the data has been collected so it can be less efficient
that the previous method.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: "than the previous method"

@andrewkroh
Copy link
Member Author

jenkins, test it

@kvch kvch merged commit 70caf0e into elastic:5.6 Aug 15, 2017
@andrewkroh andrewkroh removed the needs_backport PR is waiting to be backported to other branches. label Aug 15, 2017
andrewkroh added a commit to andrewkroh/beats that referenced this pull request Aug 15, 2017
* Add filesystem.ignore_types to ignore filesystem types

Add `filesystem.ignore_types` to the system module for ignoring filesystems
in the `filesystem` and `fsstat` metricsets. The new configuration option
accepts a list of filesystem types.

    metricbeat.modules:
    - module: system
      metricsets: [filesystem, fsstat]
      filesystem.ignore_types: [nfs, smbfs, proc, cgroups]

Closes elastic#4685

(cherry picked from commit 70caf0e)
exekias pushed a commit that referenced this pull request Aug 16, 2017
* Add filesystem.ignore_types to ignore filesystem types

Add `filesystem.ignore_types` to the system module for ignoring filesystems
in the `filesystem` and `fsstat` metricsets. The new configuration option
accepts a list of filesystem types.

    metricbeat.modules:
    - module: system
      metricsets: [filesystem, fsstat]
      filesystem.ignore_types: [nfs, smbfs, proc, cgroups]

Closes #4685

(cherry picked from commit 70caf0e)
andrewkroh added a commit to andrewkroh/beats that referenced this pull request Aug 16, 2017
…elastic#4906)

* Add filesystem.ignore_types to ignore filesystem types

Add `filesystem.ignore_types` to the system module for ignoring filesystems
in the `filesystem` and `fsstat` metricsets. The new configuration option
accepts a list of filesystem types.

    metricbeat.modules:
    - module: system
      metricsets: [filesystem, fsstat]
      filesystem.ignore_types: [nfs, smbfs, proc, cgroups]

Closes elastic#4685

(cherry picked from commit aa54a22)
exekias pushed a commit that referenced this pull request Aug 16, 2017
#4918)

* Add filesystem.ignore_types to ignore filesystem types

Add `filesystem.ignore_types` to the system module for ignoring filesystems
in the `filesystem` and `fsstat` metricsets. The new configuration option
accepts a list of filesystem types.

    metricbeat.modules:
    - module: system
      metricsets: [filesystem, fsstat]
      filesystem.ignore_types: [nfs, smbfs, proc, cgroups]

Closes #4685

(cherry picked from commit aa54a22)
@andrewkroh andrewkroh deleted the feature/mb/filesystem-ignore-types branch December 14, 2017 21:28
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…elastic#4906) (elastic#4918)

* Add filesystem.ignore_types to ignore filesystem types

Add `filesystem.ignore_types` to the system module for ignoring filesystems
in the `filesystem` and `fsstat` metricsets. The new configuration option
accepts a list of filesystem types.

    metricbeat.modules:
    - module: system
      metricsets: [filesystem, fsstat]
      filesystem.ignore_types: [nfs, smbfs, proc, cgroups]

Closes elastic#4685

(cherry picked from commit 575483a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants