Cleanup iostats field naming #4900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monicasarbu
reviewed
Aug 15, 2017
|
|
||
| type: float | ||
|
|
||
| The number of write requests that were issued to the device per second | ||
|
|
||
|
|
||
| [float] | ||
| === `system.diskio.iostat.read_byte_per_sec` | ||
| === `system.diskio.iostat.read.per_sec.bytes` |
There was a problem hiding this comment.
what about read.bytes.per_sec to be as the previous one?
There was a problem hiding this comment.
I put bytes at the end as this is the unit.
monicasarbu
reviewed
Aug 15, 2017
| "busy": extraMetrics.BusyPct, | ||
| "read": common.MapStr{ | ||
| "request": common.MapStr{ | ||
| "merge_per_sec": extraMetrics.ReadRequestMergeCountPerSec, |
There was a problem hiding this comment.
Shouldn't be merged_per_sec as in the description of the fields.yml?
There was a problem hiding this comment.
Changed it in both places to merges_per_sec
|
Looks good to me. I left a few minor comments. |
Align naming with other metricsets.
ruflin
force-pushed
the
improve-io-stat
branch
from
5064002 to
89517fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align naming with other metricsets.