[Docs] Add option to log messages in JSON #4931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dedemorton
added
the
needs_backport
andrewkroh
reviewed
Sep 7, 2017
libbeat/docs/loggingconfig.asciidoc
Outdated
| ==== `files.permissions` | ||
| ==== `logging.files.permissions` | ||
|
|
||
| //REVIEWERS: Noticed that his is not in the beat.reference.yml file. Should it be? Or is the option old? |
There was a problem hiding this comment.
Yeah, it should be in there too. Can you please add it to config.reference.yml and run make update from the top-level?
There was a problem hiding this comment.
@andrewkroh Added. Can you review the changes? Thanks!
andrewkroh
reviewed
Sep 7, 2017
| @@ -790,5 +790,9 @@ logging.files: | |||
| # Number of rotated log files to keep. Oldest files will be deleted first. | |||
| #keepfiles: 7 | |||
|
|
|||
| # The permissions mask to apply when rotating log files. The default value is 0600. | |||
There was a problem hiding this comment.
This one is different than the others. Perhaps you didn't git add the final version of this file before committing?
There was a problem hiding this comment.
@andrewkroh Good catch! Weirdness...I committed by using git commit -a -m ... so I don't know how it's possible that the files weren't updated/committed correctly. Ah well...it's fixed now.
Edit description of file permissions
dedemorton
force-pushed
the
issue#4523_docs
branch
from
a82fb79
to
6aeca40
Compare
dedemorton
added a commit
to dedemorton/beats
that referenced
this pull request
Sep 26, 2017
* [Docs] Add option to log messages in JSON * Add logging.files.permissions to full reference yml file Edit description of file permissions
dedemorton
removed
the
needs_backport
ruflin
pushed a commit
that referenced
this pull request
Sep 27, 2017
* [Docs] Add option to log messages in JSON * Add logging.files.permissions to full reference yml file Edit description of file permissions
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
* [Docs] Add option to log messages in JSON * Add logging.files.permissions to full reference yml file Edit description of file permissions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added the
loggingnamespace to (mostly) match what users see in the config file. There are a few places where we use indentation, but I think it's better to show the full path so there is no ambiguity.This adds docs for PR #4523