Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update saram dependency to v1.12 #4977

Merged
merged 5 commits into from
Aug 24, 2017
Merged

Update saram dependency to v1.12 #4977

merged 5 commits into from
Aug 24, 2017

Conversation

urso
Copy link

@urso urso commented Aug 23, 2017

  • Update to more recent sarama release
  • Add lz4 compression option
  • Add more configurable kafka versions
  • Update docs

@urso urso added libbeat needs_backport PR is waiting to be backported to other branches. review labels Aug 23, 2017
@ruflin
Copy link
Contributor

ruflin commented Aug 23, 2017

jenkins, retest it

ruflin
ruflin approved these changes Aug 23, 2017
View reviewed changes
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. WFG.

  • Should we add a changelog entry for this?
  • Do you want to have it merged as 1 commit or multiples?

@urso
Copy link
Author

urso commented Aug 23, 2017

Should we add a changelog entry for this?

Will add changelog entry

Do you want to have it merged as 1 commit or multiples?

use 'Squash and merge' please.

@tsg
Copy link
Contributor

tsg commented Aug 24, 2017

@urso intake error on this one.

@urso
Copy link
Author

urso commented Aug 24, 2017

jenkins, test it

@urso urso force-pushed the upd/sarama-v1.12-patched branch from 6939d9a to 188afe8 Compare August 24, 2017 16:05
@urso urso force-pushed the upd/sarama-v1.12-patched branch from 749a123 to fd423b9 Compare August 24, 2017 19:40
@kvch kvch merged commit 211f917 into elastic:master Aug 24, 2017
urso pushed a commit to urso/beats that referenced this pull request Aug 24, 2017
Update saram dependency to v1.12 (elastic#4977)
ca427d1 
* Update saram dependency to v1.12

* Update kafka versions and add lz4 compression

* Update kafka output docs

* Update Changelog

* Fix build

(cherry picked from commit 211f917)
@urso urso mentioned this pull request Aug 24, 2017
Merged
@urso urso removed the needs_backport PR is waiting to be backported to other branches. label Aug 24, 2017
tsg pushed a commit that referenced this pull request Aug 25, 2017
@tsg
Update saram dependency to v1.12 (#4977) (#5006)
841229d 
* Update saram dependency to v1.12

* Update kafka versions and add lz4 compression

* Update kafka output docs

* Update Changelog

* Fix build

(cherry picked from commit 211f917)
@urso urso deleted the upd/sarama-v1.12-patched branch February 19, 2019 18:55
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@tsg
Update saram dependency to v1.12 (elastic#4977) (elastic#5006)
f43824e 
* Update saram dependency to v1.12

* Update kafka versions and add lz4 compression

* Update kafka output docs

* Update Changelog

* Fix build

(cherry picked from commit 1115670)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees
No one assigned
Labels
libbeat review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@urso @ruflin @tsg @kvch