Remove ID from Runner interface

[vjsamuel]

Fixes #5153

[elasticmachine]

Can one of the admins verify this patch?

[exekias]

ok to test

[exekias]

LGTM, I think we should get rid of https://github.com/elastic/beats/blob/master/metricbeat/mb/module/wrapper.go#L40 and https://github.com/elastic/beats/blob/master/metricbeat/mb/module/wrapper.go#L132-L148

Anything against this @ruflin ?

[ruflin]

@exekias SGTM

[exekias]

👍 @vjsamuel can you remove that mentioned method? then this is good to go

[vjsamuel]

@exekias @ruflin done.

[exekias]

jenkins test it please

[exekias]

We get this error at https://beats-ci.elastic.co/job/elastic+beats+pull-request+multijob-linux/1506/beat=filebeat,label=ubuntu/console:

19:40:11 crawler/crawler.go:101: arg p.ID in printf call is a function value, not a function call

[exekias]

jenkins test it please

[exekias]

I've reproduced the issue locally, although it doesn't make sense to me, it's gone on a second run 😕

[ruflin]

Only checked travis and I see the following failure:

======================================================================
FAIL: Test if module is properly started and stoppped
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/travis/gopath/src/github.com/elastic/beats/metricbeat/tests/system/test_reload.py", line 87, in test_start_stop
    assert lines == self.output_lines()
AssertionError

@exekias Is this related what you saw locally (once)?

[exekias]

No, tests are OK, the only weird thing is around vet

[exekias]

We decided to merge this as the vet error seems spurious from some cache in jenkins, will see if it's still happening in master