-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @metadata.version to json events #5166
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- pass beat.Info into the codecs - update json encoder to include @metadata.version (for Console, File, Logstash, Redis, Kafka)
urso
force-pushed
the
event/send-version-in-meta
branch
from
September 12, 2017 14:54
b3cf193
to
da9669d
Compare
urso
added
needs_backport
PR is waiting to be backported to other branches.
review
labels
Sep 12, 2017
andrewkroh
approved these changes
Sep 12, 2017
libbeat/docs/gettingstarted.asciidoc
Outdated
document_type => "%{[@metadata][type]}" <2> | ||
} | ||
} | ||
------------------------------------------------------------------------------ | ||
<1> `%{[@metadata][beat]}` sets the first part of the index name to the value | ||
of the `beat` metadata field, and `%{+YYYY.MM.dd}` sets the second part of the | ||
of the `beat` metadata field, `%{[@metadata][version]}` sets the second part of | ||
the name to the beat's version, and `%{+YYYY.MM.dd}` sets the second part of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/second/third/
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
Looks like there are still test failures on this one. |
urso
removed
the
needs_backport
PR is waiting to be backported to other branches.
label
Sep 12, 2017
urso
pushed a commit
to urso/beats
that referenced
this pull request
Sep 12, 2017
* Add @metadata.version to json events - pass beat.Info into the codecs - update json encoder to include @metadata.version (for Console, File, Logstash, Redis, Kafka) * Update Ls docs to use the version field * Fix test build * s/second/third/ * Fix metricbeat unit tests (cherry picked from commit 46dbdbd)
andrewkroh
pushed a commit
that referenced
this pull request
Sep 12, 2017
* Add @metadata.version to json events - pass beat.Info into the codecs - update json encoder to include @metadata.version (for Console, File, Logstash, Redis, Kafka) * Update Ls docs to use the version field * Fix test build * s/second/third/ * Fix metricbeat unit tests (cherry picked from commit 46dbdbd)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
* Add @metadata.version to json events - pass beat.Info into the codecs - update json encoder to include @metadata.version (for Console, File, Logstash, Redis, Kafka) * Update Ls docs to use the version field * Fix test build * s/second/third/ * Fix metricbeat unit tests (cherry picked from commit 11e8513)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.