Fix default paths in macOS for Redis 4.0.1 #5173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monicasarbu
force-pushed
the
fix_redis_config_paths_for_logs
branch
from
a22a35c to
12fb17c
Compare
|
@tsg can you please have a look? Thanks |
tsg
reviewed
Sep 18, 2017
| @@ -6,6 +6,7 @@ var: | |||
| - /var/log/redis/redis-server.log* | |||
| os.darwin: | |||
| - /usr/local/var/log/redis/redis-server.log* | |||
| -/user/local/var/db/redis/redis-server.log* | |||
There was a problem hiding this comment.
The whitespace here seems off? Could cause issues.
tsg
reviewed
Sep 18, 2017
| @@ -12,7 +12,7 @@ | |||
| enabled: true | |||
|
|
|||
| # The Redis hosts to connect to. | |||
| #var.hosts: ["localhost:6378"] | |||
| #var.hosts: ["localhost:6379"] | |||
monicasarbu
force-pushed
the
fix_redis_config_paths_for_logs
branch
from
1446f71 to
527448b
Compare
monicasarbu
force-pushed
the
fix_redis_config_paths_for_logs
branch
from
688cb8d to
0ea1f37
Compare
|
@tsg fixed, thanks |
ruflin
approved these changes
Sep 20, 2017
|
@monicasarbu Does this need a backport? |
|
I added |
ruflin
pushed a commit
to ruflin/beats
that referenced
this pull request
Oct 9, 2017
(cherry picked from commit 23f6efe)
ruflin
removed
the
needs_backport
exekias
pushed a commit
that referenced
this pull request
Oct 10, 2017
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
(cherry picked from commit 8d5c87f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add another default path that works for newer versions of Redis (4.0.1), for macOS.