Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty dashboard due to empty query #5283

Closed
wants to merge 1 commit into from
Closed

Fix empty dashboard due to empty query #5283

wants to merge 1 commit into from

Conversation

pmusa
Copy link

@pmusa pmusa commented Oct 2, 2017

Currently the dashboard is not showing anything by default because the dashboard configuration has an empty query in it. One can easily go around it by adding a * to the query bar.

Currently the dashboard is not showing anything by default because the dashboard configuration has an empty query in it. One can easily go around it by adding a * to the query bar.
@ruflin ruflin requested a review from monicasarbu October 3, 2017 11:20
@ruflin ruflin added review needs_backport PR is waiting to be backported to other branches. labels Oct 3, 2017
@tsg
Copy link
Contributor

tsg commented Oct 3, 2017

Pinging also @simianhacker. This might have been intentional so that one is forced to select a host. But since we don't yet have a very easy way to select a host, it's probably a good idea to accept this change.

I'm adding it to our team agenda for discussion.

@tsg tsg added the discuss Issue needs further discussion. label Oct 3, 2017
@simianhacker
Copy link
Member

Argh... I'm not sure how to answer this one. If I had the option to make that a "hidden" dashboard I totally would.

@tsg
Copy link
Contributor

tsg commented Oct 23, 2017

This one was superseded by #5340. Thanks @pmusa!

@tsg tsg closed this Oct 23, 2017
@tsg tsg removed the needs_backport PR is waiting to be backported to other branches. label Oct 30, 2017
@exekias exekias deleted the pmusa-patch-1 branch November 16, 2017 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug discuss Issue needs further discussion. review v6.0.0-rc1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants