Introduce jenkins_setup command to be reused #5315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
force-pushed
the
jenkins-setup
branch
3 times, most recently
from
6811039 to
963a521
Compare
ruflin
added
:Testing
review
and removed
in progress
|
jenkins, retest it |
andrewkroh
requested changes
Oct 6, 2017
dev-tools/jenkins_setup.sh
Outdated
| #!/usr/bin/env bash | ||
| set -euox pipefail | ||
|
|
||
| : "${HOME:?Need to set HOME to a non-empty value.}" |
There was a problem hiding this comment.
I think this could go into common.bash as a function like jenkins_setup.
dev-tools/jenkins_setup.sh
Outdated
| @@ -0,0 +1,20 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| #!/usr/bin/env bash | |||
dev-tools/jenkins_setup.sh
Outdated
| #!/usr/bin/env bash | ||
|
|
||
| #!/usr/bin/env bash | ||
| set -euox pipefail |
There was a problem hiding this comment.
If this is going to be used a library by other scripts then I would omit this and the hashbangs.
jenkins_setup in common.bash will also be used for the generator tests.
ruflin
changed the title
|
@andrewkroh I updated the PR accordingly |
andrewkroh
reviewed
Oct 9, 2017
| if [ -f ".go-version" ]; then | ||
| eval "$(gvm $(cat .go-version))" | ||
| else | ||
| eval "$(gvm 1.7.5)" |
There was a problem hiding this comment.
We could remove this now that .go-version should be on this branch.
There was a problem hiding this comment.
Will do that in a follow up PR.
andrewkroh
approved these changes
Oct 9, 2017
ruflin
added a commit
to ruflin/beats
that referenced
this pull request
Oct 9, 2017
jenkins_setup in common.bash will also be used for the generator tests. (cherry picked from commit f9ac23f)
This was referenced Oct 9, 2017
ruflin
added a commit
to ruflin/beats
that referenced
this pull request
Oct 9, 2017
jenkins_setup in common.bash will also be used for the generator tests. (cherry picked from commit f9ac23f)
exekias
pushed a commit
that referenced
this pull request
Oct 10, 2017
exekias
pushed a commit
that referenced
this pull request
Oct 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jenkins_setup in common.bash will also be used for the generator tests.