Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ip address of containers to event #5379

Merged
merged 1 commit into from
Oct 26, 2017
Merged

Add ip address of containers to event #5379

merged 1 commit into from
Oct 26, 2017

Conversation

liketic
Copy link

@liketic liketic commented Oct 12, 2017

Closes #5282

@elasticmachine
Copy link
Collaborator

Can one of the admins verify this patch?

@ruflin
Copy link
Contributor

ruflin commented Oct 12, 2017

@liketic Thanks for the contribution. Could you add a CHANGELOG entry?

@ruflin
Copy link
Contributor

ruflin commented Oct 12, 2017

jenkins, test it

ruflin
ruflin approved these changes Oct 12, 2017
View reviewed changes
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFG

@liketic liketic force-pushed the feature/issues/5282 branch from a2a63d9 to cca8942 Compare October 12, 2017 08:36
@liketic
Copy link
Author

liketic commented Oct 12, 2017

@ruflin Thanks for reviewing this one. I rebased it. Thanks.

@ruflin
Copy link
Contributor

ruflin commented Oct 12, 2017

jenkins, test it

@ruflin
Copy link
Contributor

ruflin commented Oct 12, 2017

@liketic Thanks for the rebase. Tried to do a "Github commit" myself to fix the issue but a rebase is much nicer.

@liketic liketic force-pushed the feature/issues/5282 branch 2 times, most recently from f0278ac to 4362b01 Compare October 13, 2017 06:25
@liketic liketic force-pushed the feature/issues/5282 branch from 4362b01 to ebf27ef Compare October 25, 2017 01:42
@liketic
Copy link
Author

liketic commented Oct 25, 2017

Hi @ruflin Is this mergeable ? 😄

@exekias exekias merged commit 912455a into elastic:master Oct 26, 2017
@exekias
Copy link
Contributor

exekias commented Oct 26, 2017

Thank you for your contribution @liketic! 🎉

@liketic liketic deleted the feature/issues/5282 branch October 26, 2017 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liketic @elasticmachine @ruflin @exekias