-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTTP status phrase in reponse for metricsbeat http module (#5470) #5484
Conversation
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!! You will need to run make update
to update docs with the new field
Actually I was just to submit a PR as well... seems that @liketic was a little bit faster ;-)
|
@@ -37,6 +37,10 @@ | |||
type: keyword | |||
description: > | |||
The HTTP status code | |||
- name: status_phrase | |||
type: keyword | |||
description: > |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add an example, e.g. OK
for a 200 response?
Just curious if you have seen my previous comment on harmonizing the names. |
@christiangalsterer +1 on harmonizing field names. |
@christiangalsterer @ruflin I think it's OK to me. |
@liketic Could you update the PR accordingly in case @andrewkroh has no objections? |
@ruflin @christiangalsterer Apologises for the delay. I pushed 5a381dd . Please review again. |
LGTM |
jenkins, test it |
Closes #5470