Log absolute values for gauges internal metrics #5505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently don't have a way for the internal Beats metrics to register themselves as counters or gauges, so the logging code that prints the values every 30s assumes they are all counters and prints the difference since the last update. This issue has became more pressing in 6.0 because we now have several common gauges. This PR implements a temporary hack that lists these gauges in logging code. A follow up PR will create a proper solution for the next release. Part of elastic#5433.
tsg
added
bug
libbeat
review
needs_backport
andrewkroh
reviewed
Nov 2, 2017
| "beat.memstats.memory_total": true, | ||
| "beat.memstats.memory_alloc": true, | ||
| "beat.memstats.gc_next": true, | ||
| } |
There was a problem hiding this comment.
This one presents a problem because the name is not known ahead of time. Perhaps a pattern could be used to handle it or we just ignore it (I doubt anyone will be using this metric before we have a final solution).
There was a problem hiding this comment.
Yeah, I saw that one. I'd say we just ignore it in this phase and it can be handled with the real solution.
kvch
approved these changes
Nov 3, 2017
tsg
added a commit
to tsg/beats
that referenced
this pull request
Nov 3, 2017
We currently don't have a way for the internal Beats metrics to register themselves as counters or gauges, so the logging code that prints the values every 30s assumes they are all counters and prints the difference since the last update. This issue has became more pressing in 6.0 because we now have several common gauges. This PR implements a temporary hack that lists these gauges in logging code. A follow up PR will create a proper solution for the next release. Part of elastic#5433. (cherry picked from commit 6f8d5eb)
ruflin
pushed a commit
that referenced
this pull request
Nov 7, 2017
We currently don't have a way for the internal Beats metrics to register themselves as counters or gauges, so the logging code that prints the values every 30s assumes they are all counters and prints the difference since the last update. This issue has became more pressing in 6.0 because we now have several common gauges. This PR implements a temporary hack that lists these gauges in logging code. A follow up PR will create a proper solution for the next release. Part of #5433. (cherry picked from commit 6f8d5eb)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
We currently don't have a way for the internal Beats metrics to register themselves as counters or gauges, so the logging code that prints the values every 30s assumes they are all counters and prints the difference since the last update. This issue has became more pressing in 6.0 because we now have several common gauges. This PR implements a temporary hack that lists these gauges in logging code. A follow up PR will create a proper solution for the next release. Part of elastic#5433.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently don't have a way for the internal Beats metrics to register
themselves as counters or gauges, so the logging code that prints the
values every 30s assumes they are all counters and prints the difference
since the last update.
This issue has became more pressing in 6.0 because we now have several
common gauges. This PR implements a temporary hack that lists these gauges
in logging code. A follow up PR will create a proper solution for the next
release.
Part of #5433.