i5354: Harmonize field names between Packetbeat HTTP and Metricbeat Module #5521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
This was referenced Nov 6, 2017
christiangalsterer
force-pushed
the
i5354
branch
from
8ffa366 to
08fae22
Compare
|
@christiangalsterer Thanks for the PR. Could you add an entry to the Changelog under breaking changes? It's ok that it is breaking as the http module is still in beta. |
ruflin
approved these changes
Nov 7, 2017
christiangalsterer
force-pushed
the
i5354
branch
from
08fae22 to
fc6b8ef
Compare
|
Changelog updated. |
|
jenkins, test it |
|
@christiangalsterer Seems like this conflicts with a PR I merged before this one :-( Could you rebase again? |
christiangalsterer
force-pushed
the
i5354
branch
from
fc6b8ef to
d7d73df
Compare
|
Rebased and committed again ;-) |
christiangalsterer
force-pushed
the
i5354
branch
from
d7d73df to
12fae93
Compare
|
jenkins, test it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ruflin: Here the new/updated PR.