Cherry-pick #5532 to master: Fix panic if event is dropped by queue #5536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Only increase event seq-no if event has been pushed - Fix invalid ACK list if empty list is given to concat - Only execute ack handlers if number of events being ACKed > 0 - Add missing debug log when collecting first ACK in ACK list (cherry picked from commit 470b3d3)
ruflin
approved these changes
Nov 7, 2017
| @@ -53,13 +53,20 @@ func (l *ackLoop) run() { | |||
| count, events := lst.count() | |||
| l.lst.concat(&lst) | |||
|
|
|||
| // log.Debugf("ackloop: scheduledACKs count=%v events=%v\n", count, events) | |||
| // log.Debug("ACK List:") | |||
There was a problem hiding this comment.
Is this commented out on purpose?
There was a problem hiding this comment.
Yes. debug creates quite some noise if not required. There are a many debug statements in this package being commented out and only selectively uncommented when required (when debugging locally).
|
Jenkins, test it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #5532 to master branch. Original message:
Resolves: #5524