Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNS over TCP clean-up and improvements #554

Merged
merged 2 commits into from
Jan 6, 2016
Merged

DNS over TCP clean-up and improvements #554

merged 2 commits into from
Jan 6, 2016

Commits on Jan 5, 2016

  1. Refactor, clean-up and address reviews of the first DNS over TCP PR 

    * Use RFC 1035 'bytes offset' to decode DNS over TCP payloads
* Correct Streams management
* Improve error management (for Debug and published Notes)
* Tests improvement
* Split files of ```package dns```

Minor changes:
* Change the name of dnsPrivateData to dnsConnectionData to reflect
the naming used in other applayers
* Split the ```Parse()``` method in multiple functions to comply more with the code convention
 used in other applayers implementation
* Remove a PCAP file from the previous and first DNS over TCP pull request
* Introduce a README.md file
    @McStork
    McStork committed Jan 5, 2016
    Configuration menu
    Copy the full SHA
    01a9c70 View commit details
    Browse the repository at this point in the history

  2. Address @urso review of DNS over TCP 

    * Use printf format in all debug messages
* Rename err in handleDecode
* Remove a useless pointer assignement and move another one into a if statement
    @McStork
    McStork authored and McStork committed Jan 5, 2016
    Configuration menu
    Copy the full SHA
    3953a7a View commit details
    Browse the repository at this point in the history