Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify docs for system core percentages #5565

Merged
merged 1 commit into from
Nov 14, 2017

Conversation

andrewkroh
Copy link
Member

Remove statement about percentages being greater than 100% for multi-core systems.

@andrewkroh andrewkroh force-pushed the bugfix/system-core-docs branch 2 times, most recently from dc5983e to b0ec9b1 Compare November 13, 2017 17:08
@@ -91,6 +91,13 @@ https://github.com/elastic/beats/compare/v5.6.3...v5.6.4[View commits]
*Affecting all Beats*

- Fix race condition in internal logging rotator. {pull}4519[4519]
- Fix a debug statement that said a module wrapper had stopped when it hadn't. {pull}4264[4264]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewkroh Rebase issue?

Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor comment related to the changelog.

Remove statement about percentages being greater than 100% for multi-core systems.
@andrewkroh andrewkroh force-pushed the bugfix/system-core-docs branch from b0ec9b1 to fae23c9 Compare November 13, 2017 22:43
@andrewkroh
Copy link
Member Author

Fixed. I started the PR from a stale branch and did a rebase without verifying the CHANGELOG afterwards.

@ruflin ruflin merged commit 38c2219 into elastic:5.6 Nov 14, 2017
@andrewkroh andrewkroh deleted the bugfix/system-core-docs branch January 17, 2018 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants