Use add_kubernetes_metadata IP & port matching in Packetbeat
#5707
Conversation
| @@ -0,0 +1,23 @@ | |||
| package add_kubernetes_metadata | |||
There was a problem hiding this comment.
don't use an underscore in package name
| @@ -0,0 +1,23 @@ | |||
| package add_kubernetes_metadata | |||
There was a problem hiding this comment.
don't use an underscore in package name
exekias
force-pushed
the
packetbeat-kubernetes
branch
from
c4453e4 to
b041925
Compare
The code was there for Metricbeat already, this PR moves it to libbeat and adapts Packetbeat to include it
exekias
force-pushed
the
packetbeat-kubernetes
branch
from
b041925 to
a990016
Compare
| hostPorts := h.GetIndexes(pod) | ||
| var metadata []MetadataIndex | ||
|
|
||
| if pod.Status.PodIP == "" { |
There was a problem hiding this comment.
If a pod does not have an IP address, it means no metadata is availabe? Should this return an error?
There was a problem hiding this comment.
We wouldn't be dealing with this error anyway, it could make sense to log this, but I think it's just defensive code
| @@ -122,6 +122,8 @@ https://github.com/elastic/beats/compare/v6.0.0-beta2...master[Check the HEAD di | |||
|
|
|||
| *Packetbeat* | |||
|
|
|||
| - Configure good defaults for `add_kubernetes_metadata`. {pull}5707[5707] | |||
There was a problem hiding this comment.
I would add 2 change entries. One to "applies to all beats" that the IpProcessor is now available for all beats (also filebeat for example) and the other one as above that IpProcessor is set as default for PB.
There was a problem hiding this comment.
good point! I added a new entry
|
Just opened #5721 as a follow-up, with more changes needed after doing some real life usage with Packetbeat and APM |
The code was there for Metricbeat already, this PR moves it to libbeat
and adapts Packetbeat to use it, with good defaults.