Add support for Zsh completion to beats subcommand #5761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ph
force-pushed
the
feature/support-zsh-completions
branch
from
54ae988 to
536f809
Compare
ph
force-pushed
the
feature/support-zsh-completions
branch
from
536f809 to
8b90007
Compare
|
Just curious: is the command has to be run by the user even if the Beat is installed from a package? |
|
Yup in both case yes, it will generate the files required for the auto
complete same thing as the bash.
On Wed, Nov 29, 2017 at 2:38 PM Noémi Ványi ***@***.***> wrote:
Just curious: is the command has to be run by the user even if the Beat is
installed from a package?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5761 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAACgMd9NCbCJumWKpHIZfFEHNYW_VS8ks5s7bLFgaJpZM4QveHR>
.
--
ph
|
exekias
reviewed
Nov 29, 2017
CHANGELOG.asciidoc
Outdated
| @@ -16,6 +16,9 @@ https://github.com/elastic/beats/compare/v6.0.0-beta2...master[Check the HEAD di | |||
|
|
|||
| - Support dashboard loading without Elasticseach {pull}5653[5653] | |||
| - Addition and update of the following libraries: pbkdf2, terminal, windows, unix {pull}5735[5735] | |||
| - Update the command line library cobra {pull}X[X] | |||
| - Add support for Zsh for the completion subcommand {pull}X[x] | |||
| - Update the command line library cobra and add support for zsh completion {pull}5761[5761] | |||
There was a problem hiding this comment.
oh bad rebase on multiples commits.
ph
force-pushed
the
feature/support-zsh-completions
branch
from
8b90007 to
d282bb5
Compare
|
Just to keep it in mind, the cobra generator for zsh is minimal and wont handle flags for now. |
exekias
approved these changes
Nov 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the cobra library and enable zsh support for completion, you can generate the completion using the following command:
Make sure the file is in your
$fpath, you can find your currently configured path withecho $fpathand add another one withfpath = ($fpath /my/newpath)in your.zshrcNote to reviewer I can split the update of the library with the Zsh if preferred.