Ignore docker kill events in add_docker_metadata
#5788
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker kill events are caused by any signal sent to the container, not only a SIGKILL, we can safely ignore all of them, as die will always happen for the case we are really interested in.
Current code is removing forgetting metadata for containers that get a
kill
event, this PR fixes that.6.1 and master are not affected, as kill was ignored already: https://github.com/elastic/beats/blob/6.1/libbeat/common/docker/watcher.go#L237
Context on the issue: https://discuss.elastic.co/t/filebeats-docker-metadata-watcher-losing-container-from-its-list-somehow/109897